feat(cli): construct skill ship opens a pull request instead of pushing to main

[UnbreakableMJ]

Why

#25 made branch + PR the rule for this repo, but left construct skill ship hard-coding git push origin main (ship.rs:235). The tool we ship could still bypass the policy the docs state. This closes that gap.

What ship does now

Enforces bundle-drift and the §5.6 description cap (unchanged), then: resolves a feature branch → switches to it → stages by explicit name → signed UTC commit → pushes the branch with -u → opens the PR with gh.

It never pushes to the default branch, and it never merges — that stays the maintainer's call.

Branch resolution, in order

1. --branch / -b when given.
2. The current branch when it is not the default branch — so a re-run adds a commit to the branch an open PR already tracks, rather than fragmenting the work.
3. Otherwise a generated ship/<slug> from the shipped skills. Deterministic for the same skill set, which is what makes case 2's re-run land on the same branch.

The default branch comes from origin/HEAD, falling back to main when unset (fresh clones and fixture repos have no remote refs).

gh is now a dependency

Probed before the work tree is touched, so a missing gh fails with DEPENDENCY_MISSING (127) rather than stranding a committed branch the caller has to finish by hand.

If a PR for the branch is already open, gh pr create exits non-zero. That is not a ship failure — the commit is already pushed onto the branch that PR tracks — so the existing URL is looked up and returned.

Auto-sync removed

ship no longer lands anything on the default branch, so nix flake update construct would have pinned an unrelated revision. Run construct skill sync after the PR merges. --no-sync is kept as a hidden no-op so existing invocations and scripts keep working.

Output changes

	Before	After
status	shipped	pull_request_opened
added	—	branch, base_branch, pull_request_url
removed	flake_updated, synced_at	—

Dry-run additionally reports default_branch, current_branch, branch, would_create_branch, would_open_pull_request. manifest.rs updated in step — manifest_in_sync_with_cli is the guard.

Tests

Three new cases, and --no-sync dropped from the existing ones to prove it is no longer needed:

• ship_from_default_branch_plans_a_feature_branch_and_pr — the core of the rule: must plan a ship/ branch and a PR, and never target the default branch.
• ship_honours_explicit_branch
• ship_reuses_the_current_feature_branch

9 ship tests, 40 total, all passing.

Drive-by, required to get a clean gate

src/sources/skillmd.rs declared its split helper after mod tests, which trips clippy's items_after_test_module under -D warnings. Pre-existing on main and invisible because CI runs only reuse / config / description checks, never cargo. Moved the test module to the end of the file — no logic change. Without it, cargo clippy --all-targets -- -D warnings cannot pass, so this change could not be verified.

Verification

• cargo fmt --check — clean
• cargo clippy --all-targets -- -D warnings — clean
• cargo test — 40 passed, 0 failed
• Exercised the built binary against a live throwaway fixture: from main it plans ship/demo, would_create_branch: true, would_open_pull_request: true.
• Repo gates: description cap and reuse lint pass.

Note that CI does not build or test construct-cli — worth a follow-up, since that is why the clippy break above sat unnoticed.

🤖 Generated with Claude Code

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.