Draft
Conversation
Contributor
Author
|
waiting for #26 merged |
Contributor
Author
|
need cleaned history |
nmellado
reviewed
Apr 4, 2024
Contributor
nmellado
left a comment
nmellado
left a comment
There was a problem hiding this comment.
Sounds good after rebase 👍
Contributor
Author
|
The cleanup has not yet been done in house (locally), the process is going to modify a lot of files and could involve conflicts with all current pull requests. I prefer to do a main rebase with as few PRs as possible, clean up and merge afterwards to avoid managing too many conflicts on each of the remaining PRs. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmake-format all
clang-format all
remove empty commens (cmake, c++)
Update scripts to clean all project
Check diff on CI