Merged
Conversation
Added endpoint Saga and ui with reacstrap
Added markup and styles for table Added utils to parse data
Refactored allocation request UI flow for team view modal tests
Added coverage for loading/errors Formatting of resource
Renamed and reworked file structure Implemented css module
Added units to entry Changed heading for usage Added 0 usage Changed exceptions in backend
* Task/fp 515 install cortal icons (#90) * Task/fp 228/fp 515 isntall cortal icons (#89) * FP-515: Add Icon component from FP-354 * FP-515: Add Icon component usage from FP-354 * FP-515: Install Cortal 1.2 - Disable linting of `icon.fonts.css`. - Support WOFF in Webpack config. - Update several files (and tests) to use new icon names: - AppIcon - AppBrowser - DataFilesListingCell - DataFilesSidebar - DataFilesToolbar - Sidebar - TicketModal - Replace old Core Portal font with Cortal Icons font. - Migrate font styles to their own stylesheet. - Add icon aliases: - icon-collapse (icon-contract) * FP-515: Disable an "extra icon" * FP-515: Fix neglected instances of `icon-upload` * FP-228: Hide accessible Icon text * FP-228: Allow extra spaces in CSS before ruleset * Task/fp 354 message component (#88) * WIP: FP-354: Add component, icon sub-comp, tests To Do: - Run tests - Fix lint errors - Create tests for icon sub-component - Graduate icon sub-component to component * FP-354: Fix test * FP-354: Fix ES Lint error. Remove test CSS. * FP-354: Test sub-component * FP-354: Graduate MessageIcon to Icon * FP-354: Support `AppIcon` use of `Icon` * FP-354: Revert test tweaks to jest.config.js roots * FP-354: Support shortcut path to load new commons * FP-354: Accessible icon text. Missing icon class. * FP-354: Message text and icon text as `children` * FP-354: Styles for Message's * FP-354: Use `Message` in `DataFilesTable.js` * Quick: CSS lint allow align single-line rulesets * FP-354: Add missing `success` type * FP-354: Success type and fixes * FP-354: Fixes. Require icon. Color info type. * FP-534: Comments. Color var naming tweak. * FP-354: Fix AppIcon test fail (missing icon class) * FP-354: Expand tests. Simplify class match syntax. * Noop: Remove style remark from function comment * FP-354: CHoose different icon for `info` type * FP-515/FP-317: Update icons * Task/fp 537 add section for ui patterns (#93) * FP-537: New Section "UI Patterns" * FP-537: Update Sidebar tests * FP-537: More accurate `isDebug` comment * FP-537: Use new icon for 'UI Patterns' section * FP-357: Document `UIPatterns` component * FP-515/FP-354: Cleanup Icons & Messages * FP-354: More tests with less code * FP-354/FP-537: Add Message UI Patterns (#95) Follow up to FP-354 that was pending FP-537 * Quick: Remove outdated comments * FP-354/FP-537: Context for Message UI Patterns * FP-354/FP-537: Fix Unit Test i.e. Remove styleName * FP-354: Render/Style Links in UPatternsMessages * FP-537: Unset Bootstrap styles for `code` tag * FP-354: Replace `Action` w/ `link` tagged template * FP-515 (with FP-354): Change Icon Size to 18px … And replace `.app-icon` and `.category-icon` with `.icon`.
(includes fixes)
jchuahtacc
approved these changes
Aug 5, 2020
owaisj
approved these changes
Aug 5, 2020
rstijerina
added a commit
that referenced
this pull request
Aug 7, 2020
* Allocations usage by user Added endpoint Saga and ui with reacstrap * Refactored sagas * UsageDisplayed on modal Added markup and styles for table Added utils to parse data * Allocation modals tests Refactored allocation request UI flow for team view modal tests * Test Coverage and UI tweaks Added coverage for loading/errors Formatting of resource * Refactored UsageTable Renamed and reworked file structure Implemented css module * Modals in separate directory * CSS modules and test tweaks * Various Fixes Added units to entry Changed heading for usage Added 0 usage Changed exceptions in backend * Fixed units * Added JSDoc comments to utils * Task/FP-204: UI tweak (#114) Quick solution for more space * FP-204: UI: Fix unit test (late commit) * Changed wording for initial state of modal Clear the view in between openings Active user check * Task/fp 204 ui tweak with fp 557 (#133) * Allocations usage by user Added endpoint Saga and ui with reacstrap * Refactored sagas * UsageDisplayed on modal Added markup and styles for table Added utils to parse data * Allocation modals tests Refactored allocation request UI flow for team view modal tests * Test Coverage and UI tweaks Added coverage for loading/errors Formatting of resource * Refactored UsageTable Renamed and reworked file structure Implemented css module * Modals in separate directory * CSS modules and test tweaks * Various Fixes Added units to entry Changed heading for usage Added 0 usage Changed exceptions in backend * Fixed units * Added JSDoc comments to utils * FP-204: UI: Swap contact card bold, and less bold * Task/fp 515 fp 354 support messages and new icons (#91) * Task/fp 515 install cortal icons (#90) * Task/fp 228/fp 515 isntall cortal icons (#89) * FP-515: Add Icon component from FP-354 * FP-515: Add Icon component usage from FP-354 * FP-515: Install Cortal 1.2 - Disable linting of `icon.fonts.css`. - Support WOFF in Webpack config. - Update several files (and tests) to use new icon names: - AppIcon - AppBrowser - DataFilesListingCell - DataFilesSidebar - DataFilesToolbar - Sidebar - TicketModal - Replace old Core Portal font with Cortal Icons font. - Migrate font styles to their own stylesheet. - Add icon aliases: - icon-collapse (icon-contract) * FP-515: Disable an "extra icon" * FP-515: Fix neglected instances of `icon-upload` * FP-228: Hide accessible Icon text * FP-228: Allow extra spaces in CSS before ruleset * Task/fp 354 message component (#88) * WIP: FP-354: Add component, icon sub-comp, tests To Do: - Run tests - Fix lint errors - Create tests for icon sub-component - Graduate icon sub-component to component * FP-354: Fix test * FP-354: Fix ES Lint error. Remove test CSS. * FP-354: Test sub-component * FP-354: Graduate MessageIcon to Icon * FP-354: Support `AppIcon` use of `Icon` * FP-354: Revert test tweaks to jest.config.js roots * FP-354: Support shortcut path to load new commons * FP-354: Accessible icon text. Missing icon class. * FP-354: Message text and icon text as `children` * FP-354: Styles for Message's * FP-354: Use `Message` in `DataFilesTable.js` * Quick: CSS lint allow align single-line rulesets * FP-354: Add missing `success` type * FP-354: Success type and fixes * FP-354: Fixes. Require icon. Color info type. * FP-534: Comments. Color var naming tweak. * FP-354: Fix AppIcon test fail (missing icon class) * FP-354: Expand tests. Simplify class match syntax. * Noop: Remove style remark from function comment * FP-354: CHoose different icon for `info` type * FP-515/FP-317: Update icons * Task/fp 537 add section for ui patterns (#93) * FP-537: New Section "UI Patterns" * FP-537: Update Sidebar tests * FP-537: More accurate `isDebug` comment * FP-537: Use new icon for 'UI Patterns' section * FP-357: Document `UIPatterns` component * FP-515/FP-354: Cleanup Icons & Messages * FP-354: More tests with less code * FP-354/FP-537: Add Message UI Patterns (#95) Follow up to FP-354 that was pending FP-537 * Quick: Remove outdated comments * FP-354/FP-537: Context for Message UI Patterns * FP-354/FP-537: Fix Unit Test i.e. Remove styleName * FP-354: Render/Style Links in UPatternsMessages * FP-537: Unset Bootstrap styles for `code` tag * FP-354: Replace `Action` w/ `link` tagged template * FP-515 (with FP-354): Change Icon Size to 18px … And replace `.app-icon` and `.category-icon` with `.icon`. * FP-557: New `<dl>` Component * FP-204/FP-557: Use DL UI Comp in Allocations Modal * FP-557: Finish Unit Tests * Quick: Allow `composes` to Pass CSS LInter * FP-204: UI: Quick: Remove extra code (from merge) * FP-204/FP-557: Remove margin on horz DL Co-authored-by: Owais Jamil <ojamil@tacc.utexas.edu> * Changed allocation computation * Fix storage systems showing 0gb * Badge fix * Contact information padding removed * Cell width and font size Co-authored-by: W. Bomar <62723358+tacc-wbomar@users.noreply.github.com> Co-authored-by: Wesley Bomar <wbomar@tacc.utexas.edu> Co-authored-by: Sal Tijerina <r.sal.tijerina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
Add use of
DescriptionListto PR #68.PR Status:
Related Jira tickets:
Summary of Changes:
DescriptionList.DescriptionList.Testing Steps:
UI Photos:
Allocations Modal
DescriptionListComponentDescriptionList Before
DescriptionList After
Notes:
Non-functional, (90%) non-visual, change.