fix: Improve installation and settings UX#296
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
055a03b to
228dd0f
Compare
228dd0f to
922c2e1
Compare
|
It should also work now even if no Flatpak remote was configured at all -- Wheel Wizard will also add the |
Purpose of this PR:
Fix all annoying, long-standing, but easy-to-fix bugs users have had to deal with related to setting up Wheel Wizard, especially on Linux.
How to Test:
Test both unsandboxed and sandboxed (Flatpak) versions of Wheel Wizard and check whether the initial setup works without issues (also, for example, if multiple branches exist for Dolphin Flatpak). Test whether the Dolphin Flatpak installation works without privileges. Ensure that the file pop-up is not shown anymore for Flatpak Wheel Wizard since it does not make any sense. Check whether Wheel Wizard correctly identifies a native Dolphin installation on Linux. Also check whether the fixed newlines are displayed correctly in other environments.
What Has Been Changed:
flatpak listrather thanflatpak infowhich failed if more than one branch existed with a Dolphin installation. We do not care about installation branches.flathubuser remote is added if it did not already exist.dolphin-emuis installed on Linux with sandboxed Wheel Wizard has been fixed to test running the host commanddolphin-emu --version(the command is always available in the Wheel Wizard Flatpak's environment).IsFlatpakDolphinFilePathhave been fixed to not depend on additional queries toPathManagerto avoid inconsistencies with the used dolphin location in the different code paths.Related Issue Link:
#185
Checklist before merging