Skip to content

fix: Improve installation and settings UX#296

Merged
matellush merged 1 commit into
devfrom
fix/installation-and-settings-ux
Jul 9, 2026
Merged

fix: Improve installation and settings UX#296
matellush merged 1 commit into
devfrom
fix/installation-and-settings-ux

Conversation

@matellush

@matellush matellush commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

Purpose of this PR:

Fix all annoying, long-standing, but easy-to-fix bugs users have had to deal with related to setting up Wheel Wizard, especially on Linux.

How to Test:

Test both unsandboxed and sandboxed (Flatpak) versions of Wheel Wizard and check whether the initial setup works without issues (also, for example, if multiple branches exist for Dolphin Flatpak). Test whether the Dolphin Flatpak installation works without privileges. Ensure that the file pop-up is not shown anymore for Flatpak Wheel Wizard since it does not make any sense. Check whether Wheel Wizard correctly identifies a native Dolphin installation on Linux. Also check whether the fixed newlines are displayed correctly in other environments.

What Has Been Changed:

  • The Dolphin Flatpak detection has been fixed to use flatpak list rather than flatpak info which failed if more than one branch existed with a Dolphin installation. We do not care about installation branches.
  • Translations have been updated to account for the fact that Flatpak Dolphin is not installed system-wide anymore, but per-user. For this, the official Dolphin Flatpak remote is added to the user configuration and then used to install Dolphin without any admin privs. Also, the flathub user remote is added if it did not already exist.
  • The Wheel Wizard Flatpak will also get the Dolphin Flatpak installation pop-up now that it is an unprivileged per-user installation which we can perform due to having to escape the sandbox already.
  • The Wheel Wizard Flatpak will not display the file picker pop-up anymore for the Dolphin executable since it cannot work.
  • The detection for whether or not dolphin-emu is installed on Linux with sandboxed Wheel Wizard has been fixed to test running the host command dolphin-emu --version (the command is always available in the Wheel Wizard Flatpak's environment).
  • The settings validation was fixed to allow Flatpak Dolphin file paths even if Wheel Wizard does not recognize, for example, the app ID of Dolphin.
  • The checks for IsFlatpakDolphinFilePath have been fixed to not depend on additional queries to PathManager to avoid inconsistencies with the used dolphin location in the different code paths.
  • The English translation has received new text for the detected Dolphin executable for Wheel Wizard on Linux (has to be translated to other languages still, but should be similar to the folder pop-up; I was too lazy to do this).
  • Translations were fixed to correctly display newlines with the correct YAML syntax.
  • The app ID for the Flatpak permissions fixing is determined using regex matching based on the Dolphin command that was configured, which should work for most use cases and enable using Dolphin builds with different app IDs.

Related Issue Link:

#185

Checklist before merging

  • You have created relevant tests

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: ebf95d4d-a9c6-4260-8093-0ee4497ac53c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/installation-and-settings-ux

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@matellush matellush enabled auto-merge July 4, 2026 21:17
@matellush matellush force-pushed the fix/installation-and-settings-ux branch from 055a03b to 228dd0f Compare July 4, 2026 22:12
@matellush matellush self-assigned this Jul 4, 2026
@matellush matellush requested a review from patchzyy July 4, 2026 22:42
@matellush matellush force-pushed the fix/installation-and-settings-ux branch from 228dd0f to 922c2e1 Compare July 5, 2026 22:03
@matellush

Copy link
Copy Markdown
Collaborator Author

It should also work now even if no Flatpak remote was configured at all -- Wheel Wizard will also add the flathub user remote if it did not exist already.

@matellush matellush requested a review from DirkDoes July 8, 2026 09:39
@matellush matellush merged commit 749f5b0 into dev Jul 9, 2026
2 checks passed
@matellush matellush deleted the fix/installation-and-settings-ux branch July 9, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants