[Fix] Comic import fails due to issue having a non-integer comic number #53
Conversation
* Added migration to modify existing data to a 3-padded field Charfield (ex. #1) * Modified the comicimporter.py to add the issue number as a 3-padded String. * Added the comicarchive api to use it's IssueString function.
|
Thanks @bpepple for all this work! I feel a tad ashamed realizing that I'm not PEP-8 compliant. Haha. This definitely will help others be able to work on it. I was excited to see that you're using the comicapi from comictagger. I was actually looking at that for inspiration for support of comicinfo.xml, which is probably why you added it. I'm debating maybe separating comicapi out into a separate repo in the future so that we can maintain it a bit better, but for now it's fine where it is. I'll test this a little bit soon before merging. My main concern is sorting by issue number, but it looks like comicapi handles this, if I'm reading this right. |
|
The IssueString function with a padding of 3 should keep sorting correct (tho with Action Comics hitting 1,000 soon it might need to be changed down the road to 4). It might also make more sense to order by publication date tho, instead of by the issue number. I'm thinking about issues like Astro City #½ and the various #0 issues DC and Marvel have put out, but haven't really looked too hard at it just yet to see if there are any downsides to doing that. |
|
There's an idea! That would actually make more sense anyway. Are there any Star Wars like ordering in any series that you're aware of? |
|
Not that I'm aware of off the top of my head, but I'll look into it some more later today. |
|
I moved my comicapi repo into a publicly viewable repo (and also rename it to comicarchive). As I've got free time I'll clean it up a bit so eventually it can be a separately installed library. |
2 participants
Here's a fix for bug #51