Fix typing of RegexHighlighter.highlights using ClassVar#3925
Closed
SudheerKovvuru wants to merge 2 commits intoTextualize:masterfrom
Closed
Fix typing of RegexHighlighter.highlights using ClassVar#3925SudheerKovvuru wants to merge 2 commits intoTextualize:masterfrom
SudheerKovvuru wants to merge 2 commits intoTextualize:masterfrom
Conversation
willmcgugan
requested changes
Jan 22, 2026
| """Applies highlighting from a list of regular expressions.""" | ||
|
|
||
| highlights: List[str] = [] | ||
| highlights: ClassVar[tuple[str | re.Pattern[str], ...]] = () |
Member
There was a problem hiding this comment.
But it is a list. And while it does coincidentally work with a pattern, I can think of no good reason to pre-compile it. the re library will cache compilation anyway.
Contributor
Author
There was a problem hiding this comment.
Thanks for the clarification, that makes sense.
I’ve updated the type to ClassVar[tuple[str, ...]] to better reflect actual usage and avoid implying pre-compilation.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review!
Since the issue has now been resolved and merged upstream via #3939, I’m closing this PR to avoid duplication.
Appreciate the clarification and feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
AI?
AI generated PRs may be accepted, but only if @willmcgugan has responded on an issue or discussion.
Checklist
Description
Please describe your changes here.
This PR updates the typing of
RegexHighlighter.highlightsto explicitly mark it as a class variable usingClassVarand an immutable tuple.The change is limited to typing and does not alter runtime behavior.
Note: Some rendering-related tests fail locally on Windows (Python 3.11), which appears to be environment-specific and unrelated to this change.
Important: Link to an issue or discussion regarding these changes.
Fixes #3888