Skip to content

Fix typing of RegexHighlighter.highlights using ClassVar #3925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SudheerKovvuru wants to merge 2 commits into from
Closed

Fix typing of RegexHighlighter.highlights using ClassVar #3925

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aae4e64
Fix typing of RegexHighlighter.highlights using ClassVar
SudheerKovvuru Jan 8, 2026
da11266
Adjust highlights type to tuple[str] per review
SudheerKovvuru Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rich/highlighter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import re
from abc import ABC, abstractmethod
from typing import List, Union
from typing import ClassVar, Union

from .text import Span, Text

Expand Down Expand Up @@ -61,7 +61,7 @@ def highlight(self, text: Text) -> None:
class RegexHighlighter(Highlighter):
"""Applies highlighting from a list of regular expressions."""

highlights: List[str] = []
highlights: ClassVar[tuple[str, ...]] = ()
base_style: str = ""

def highlight(self, text: Text) -> None:
Expand Down