Cataloged the inlined ESLint stack deps#28825
Conversation
ref https://linear.app/tryghost/ - moved 'globals' (17.6.0), 'eslint-plugin-ghost' (3.5.0), 'eslint-plugin-react' (7.37.5), and 'typescript-eslint' (8.58.0) into the default catalog in pnpm-workspace.yaml - swapped every inline reference in package.json files to 'catalog:' - these were inlined during the ESLint 9 / flat config migration because the only consumer at the time (apps/admin) had them inline; with 13+ consumers now, the catalog is the single source of truth No version changes — just consolidating the version pin location.
WalkthroughThis PR adds Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx build @tryghost/activitypub |
✅ Succeeded | 2s | View ↗ |
nx build @tryghost/portal |
✅ Succeeded | 1s | View ↗ |
nx build @tryghost/sodo-search |
✅ Succeeded | 1s | View ↗ |
nx build @tryghost/announcement-bar |
✅ Succeeded | <1s | View ↗ |
nx build @tryghost/signup-form |
✅ Succeeded | <1s | View ↗ |
nx build @tryghost/comments-ui |
✅ Succeeded | <1s | View ↗ |
nx build @tryghost/admin-toolbar |
✅ Succeeded | <1s | View ↗ |
nx run-many -t test:unit -p @tryghost/activityp... |
✅ Succeeded | 27s | View ↗ |
Additional runs (15) |
✅ Succeeded | ... | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-06-23 14:49:36 UTC
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28825 +/- ##
=======================================
Coverage 74.07% 74.07%
=======================================
Files 1560 1560
Lines 134883 134883
Branches 16332 16332
=======================================
Hits 99912 99912
- Misses 33961 33991 +30
+ Partials 1010 980 -30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|

Summary
globals(17.6.0),eslint-plugin-ghost(3.5.0),eslint-plugin-react(7.37.5), andtypescript-eslint(8.58.0) into the default catalog inpnpm-workspace.yaml.package.jsonfiles tocatalog:.apps/admin. With 13+ consumers now, the catalog is the single source of truth.Test plan