Skip to content

Cataloged the inlined ESLint stack deps#28825

Merged
9larsons merged 1 commit into
mainfrom
chore-catalog-eslint-deps
Jun 23, 2026
Merged

Cataloged the inlined ESLint stack deps#28825
9larsons merged 1 commit into
mainfrom
chore-catalog-eslint-deps

Conversation

@9larsons

@9larsons 9larsons commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Moved globals (17.6.0), eslint-plugin-ghost (3.5.0), eslint-plugin-react (7.37.5), and typescript-eslint (8.58.0) into the default catalog in pnpm-workspace.yaml.
  • Swapped every inline reference in workspace package.json files to catalog:.
  • These were inlined during the per-slice ESLint 9 / flat config migration because the only consumer at the time was apps/admin. With 13+ consumers now, the catalog is the single source of truth.

Test plan

  • CI lint passes across every affected workspace

ref https://linear.app/tryghost/

- moved 'globals' (17.6.0), 'eslint-plugin-ghost' (3.5.0),
  'eslint-plugin-react' (7.37.5), and 'typescript-eslint' (8.58.0) into
  the default catalog in pnpm-workspace.yaml
- swapped every inline reference in package.json files to 'catalog:'
- these were inlined during the ESLint 9 / flat config migration because
  the only consumer at the time (apps/admin) had them inline; with 13+
  consumers now, the catalog is the single source of truth

No version changes — just consolidating the version pin location.
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

This PR adds eslint-plugin-ghost, eslint-plugin-react, globals, and typescript-eslint to the pnpm workspace catalog, then updates the root package, e2e package, and multiple app package manifests to replace pinned devDependency versions with catalog: references for those tools. The affected manifests are in activitypub, admin-toolbar, admin-x-design-system, admin-x-framework, admin-x-settings, admin, announcement-bar, comments-ui, portal, posts, shade, signup-form, sodo-search, and stats. It also bumps apps/activitypub from 3.1.44 to 3.1.45.

Possibly related PRs

  • TryGhost/Ghost#27886: Also switches many workspace devDependencies to catalog: references for the same linting packages added here to pnpm-workspace.yaml.
  • TryGhost/Ghost#28803: Overlaps directly with apps/activitypub/package.json ESLint tooling dependency changes.
  • TryGhost/Ghost#28801: Also modifies apps/comments-ui/package.json ESLint-related devDependency version sources.

Suggested reviewers

  • EvanHahn
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Cataloged the inlined ESLint stack deps' clearly and concisely describes the main change: moving ESLint dependencies into the pnpm workspace catalog.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description accurately describes the changeset, detailing the migration of four ESLint-related dependencies into the pnpm catalog and the rationale for this refactoring.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore-catalog-eslint-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Jun 23, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit f2c0216

Command Status Duration Result
nx build @tryghost/activitypub ✅ Succeeded 2s View ↗
nx build @tryghost/portal ✅ Succeeded 1s View ↗
nx build @tryghost/sodo-search ✅ Succeeded 1s View ↗
nx build @tryghost/announcement-bar ✅ Succeeded <1s View ↗
nx build @tryghost/signup-form ✅ Succeeded <1s View ↗
nx build @tryghost/comments-ui ✅ Succeeded <1s View ↗
nx build @tryghost/admin-toolbar ✅ Succeeded <1s View ↗
nx run-many -t test:unit -p @tryghost/activityp... ✅ Succeeded 27s View ↗
Additional runs (15) ✅ Succeeded ... View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-06-23 14:49:36 UTC

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.07%. Comparing base (01c566a) to head (f2c0216).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #28825   +/-   ##
=======================================
  Coverage   74.07%   74.07%           
=======================================
  Files        1560     1560           
  Lines      134883   134883           
  Branches    16332    16332           
=======================================
  Hits        99912    99912           
- Misses      33961    33991   +30     
+ Partials     1010      980   -30     
Flag Coverage Δ
admin-tests 55.16% <ø> (ø)
e2e-tests 76.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@9larsons 9larsons enabled auto-merge (squash) June 23, 2026 14:51
@9larsons 9larsons merged commit df26903 into main Jun 23, 2026
55 checks passed
@9larsons 9larsons deleted the chore-catalog-eslint-deps branch June 23, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant