Skip to content

Removed the customFonts labs flag - #29886

Open
ErisDS wants to merge 1 commit into
mainfrom
codex/cleanup-custom-fonts-lab
Open

Removed the customFonts labs flag#29886
ErisDS wants to merge 1 commit into
mainfrom
codex/cleanup-custom-fonts-lab

Conversation

@ErisDS

@ErisDS ErisDS commented Aug 11, 2026

Copy link
Copy Markdown
Member

Summary

  • Removes the obsolete customFonts Labs registration.
  • Custom fonts remain generally available; no runtime behavior is changed.

Testing

  • UPDATE_SNAPSHOT=1 pnpm test:single test/unit/shared/labs.test.js
  • UPDATE_SNAPSHOT=1 pnpm exec vitest run -c vitest.config.db.ts test/e2e-api/admin/config.test.js test/e2e-api/content/settings.test.js
  • pnpm build

no ref

Custom fonts have been generally available since December 2024, and no runtime code still reads this flag.
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 23a16d4c-b4dc-48cf-bdaa-37471c2a9a0b

📥 Commits

Reviewing files that changed from the base of the PR and between 95b89f6 and 84a0e17.

📒 Files selected for processing (1)
  • ghost/core/core/shared/labs.js
💤 Files with no reviewable changes (1)
  • ghost/core/core/shared/labs.js

Walkthrough

Removed customFonts from GA_FEATURES in labs.js. The flag is no longer forced on by getAll or included in GA_KEYS and getAllFlags.

Possibly related PRs

  • TryGhost/Ghost#29881: Both changes remove a permanently enabled Labs flag from the GA feature list.
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: removing the obsolete customFonts Labs flag.
Description check ✅ Passed The description accurately explains the customFonts Labs removal, unchanged runtime behavior, and completed tests.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/cleanup-custom-fonts-lab

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Aug 11, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit 84a0e17

Command Status Duration Result
nx run ghost:test:ci:integration ✅ Succeeded 3m 2s View ↗
nx run ghost:test:integration ✅ Succeeded 3m 3s View ↗
nx run ghost:test:legacy ✅ Succeeded 2m 58s View ↗
nx run ghost:test:e2e ✅ Succeeded 2m 39s View ↗
nx run ghost-monorepo:lint:boundaries ✅ Succeeded 24s View ↗
nx run-many -t test:unit -p ghost ✅ Succeeded 29s View ↗
nx run-many -t lint -p ghost,ghost-monorepo ✅ Succeeded 20s View ↗
nx run-many --target=build --projects=tag:publi... ✅ Succeeded 1s View ↗
nx run @tryghost/admin:build ✅ Succeeded 3s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-08-11 15:18:56 UTC

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.46%. Comparing base (95b89f6) to head (84a0e17).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #29886      +/-   ##
==========================================
+ Coverage   75.42%   75.46%   +0.03%     
==========================================
  Files        1606     1606              
  Lines      140657   140656       -1     
  Branches    17431    17443      +12     
==========================================
+ Hits       106095   106147      +52     
+ Misses      33514    33432      -82     
- Partials     1048     1077      +29     
Flag Coverage Δ
e2e-tests 77.61% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant