Conversation
…STAR, WIDTHTRUNC, port widths
…LENAME, IMPORTSTAR, WIDTHTRUNC, and a write-enable line from utoss_riscv.sv
| zba uut(.reg1(reg1) | ||
| , .reg2(reg2) | ||
| , .inst(inst) | ||
| , .funct3(3'b000) //these were missing |
Member
There was a problem hiding this comment.
Suggested change
| , .funct3(3'b000) //these were missing | |
| , .funct3(3'b000) |
…conflict resolution issue
…eferencing old filenames
🔧 DE1-SoC Synthesis Report Summary Diff📊 Fitter Summary (.fit.summary)@@ -1,4 +1,4 @@
-Fitter Status : Successful - Sun Mar 15 05:34:01 2026
+Fitter Status : Successful - Thu Mar 19 14:52:55 2026
Quartus Prime Version : 25.1std.0 Build 1129 10/21/2025 SC Lite Edition
Revision Name : utoss-risc-v
Top-level Entity Name : top⏱️ Timing Analysis Summary (.sta.summary)No changes detected Comparing synthesis results from main branch vs. this PR |
| , .memory_address ( memory__address ) | ||
| , .memory_data ( mem_load_result ) | ||
| , .write_enable ( memory__write_enable ) | ||
| , .write_enable ( memory__write_enable[0] ) |
Member
There was a problem hiding this comment.
i think it would be better to expand write_enable signal in Logger to support 4 bits, just so that we are not missing out on this info in the debug logs.
| else if (opcode == RType) next_state = EXECUTER; | ||
|
|
||
| else if (opcode == IType_logic) next_state = EXECUTEI; | ||
| else if (opcode == IType_logic) next_state = EXECUTEI; // "7'b0010011" was reverted back to "IType_logic" |
Member
There was a problem hiding this comment.
Suggested change
| else if (opcode == IType_logic) next_state = EXECUTEI; // "7'b0010011" was reverted back to "IType_logic" | |
| else if (opcode == IType_logic) next_state = EXECUTEI; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
all 5 changes seem to be present in this one