🎨 Palette: [UX improvement] Enhance Accessibility and Focus States of Filter Pills#203
🎨 Palette: [UX improvement] Enhance Accessibility and Focus States of Filter Pills#203aarjava wants to merge 2 commits into
Conversation
Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
🎨 Palette: Accessibility & Focus States for Filter Pills
💡 What:
Added
aria-pressedandfocus-visiblering styles to the Filter Pill toggle buttons. Also added anaria-label="Clear all filters"andaria-hidden="true"to the inner X icon on the Clear button, along with an explicit focus ring.🎯 Why:
Custom toggle buttons using framer-motion against dark backgrounds lacked explicit focus states, making keyboard navigation difficult to track. Additionally, screen readers had no way of knowing if a filter was toggled on or off without
aria-pressed, and the clear button was an icon-only button without an accessible label.♿ Accessibility:
aria-pressed={isSelected}to toggle buttons.aria-label="Clear all filters"to the Clear button.aria-hidden="true"to the decorative X icon.focus-visible:ring-2 focus-visible:ring-[#4C8BF5]with offsets for clear keyboard focus indication.PR created automatically by Jules for task 13146436513558121638 started by @aarjava