Skip to content

🎨 Palette: [UX improvement] Enhance Accessibility and Focus States of Filter Pills #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aarjava wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −3
Open

🎨 Palette: [UX improvement] Enhance Accessibility and Focus States of Filter Pills #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e0cbcc
feat(ui): add a11y and focus states to filter pills
google-labs-jules[bot] Jun 13, 2026
ecc41b4
feat(ui): add a11y and focus states to filter pills
google-labs-jules[bot] Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-06-13 - Focus Visible on Custom Filter Pills
**Learning:** For custom toggle buttons (like filter pills) that use `framer-motion` and conditional styling, relying on browser default focus states is often insufficient against dark backgrounds (e.g. `bg-neutral-800`). Explicitly adding `focus-visible:ring-2`, an offset, and `aria-pressed` drastically improves keyboard navigation clarity. Additionally, icon-only "Clear" buttons inside these filter groups frequently lack `aria-label`s.
**Action:** Always check custom filter/toggle components for `aria-pressed` and robust `focus-visible` states, especially against dark themes.
8 changes: 5 additions & 3 deletions src/components/dashboard/filter-pills.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,10 @@ export function FilterPills({ options, selected, onToggle, onClear, className }:
<motion.button
key={option.id}
onClick={() => onToggle(option.id)}
aria-pressed={isSelected}
transition={{ duration: 0.15 }}
className={cn(
'inline-flex items-center gap-2 rounded-full px-3 py-1.5 text-xs font-medium transition-all',
'inline-flex items-center gap-2 rounded-full px-3 py-1.5 text-xs font-medium transition-all focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-[#4C8BF5] focus-visible:ring-offset-2 focus-visible:ring-offset-black',
isSelected
? 'bg-[#4C8BF5] text-white shadow-sm'
: 'bg-neutral-800 text-neutral-300 hover:bg-neutral-700'
Expand All @@ -60,9 +61,10 @@ export function FilterPills({ options, selected, onToggle, onClear, className }:
{hasSelection && onClear && (
<button
onClick={onClear}
className="inline-flex items-center gap-1 rounded-full px-3 py-1.5 text-xs font-medium text-neutral-400 hover:text-neutral-300 transition-colors"
aria-label="Clear all filters"
className="inline-flex items-center gap-1 rounded-full px-3 py-1.5 text-xs font-medium text-neutral-400 hover:text-neutral-300 transition-colors focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-[#4C8BF5] focus-visible:ring-offset-2 focus-visible:ring-offset-black"
>
<X className="size-3" />
<X className="size-3" aria-hidden="true" />
Clear
</button>
)}
Expand Down
Loading