🎨 Palette: Improve accessibility of More Options menu button#209
🎨 Palette: Improve accessibility of More Options menu button#209aarjava wants to merge 2 commits into
Conversation
Added `aria-label`, `aria-expanded`, and `aria-haspopup` to the "More actions" (`MoreHorizontal`) trigger button in `EventAnnotations.tsx` to ensure proper screen reader discoverability and state announcement for the context menu. Also added `aria-hidden="true"` to the purely decorative icon. Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Added `aria-label`, `aria-expanded`, and `aria-haspopup` to the "More actions" (`MoreHorizontal`) trigger button in `EventAnnotations.tsx` to ensure proper screen reader discoverability and state announcement for the context menu. Also added `aria-hidden="true"` to the purely decorative icon. Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
1 participant
🎨 Palette: Added ARIA attributes to icon-only More Options menu button
💡 What: Added
aria-label,aria-expanded,aria-haspopup, andaria-hiddenattributes to the "More Options" (MoreHorizontal) icon-only button within theEventAnnotationscomponent's action menu.🎯 Why: To ensure screen readers can correctly identify the button as a menu trigger ("More actions"), understand whether the context menu is currently open or closed, and avoid reading out meaningless decorative icons.
📸 Before/After: N/A (Non-visual accessibility change)
♿ Accessibility:
aria-label="More actions"for clear identification.aria-expanded={showActionsFor === thread.id}to communicate state.aria-haspopup="menu"to indicate functionality.aria-hidden="true"to the purely visualMoreHorizontalicon.PR created automatically by Jules for task 8086081519481075710 started by @aarjava