Skip to content

🎨 Palette: Improve accessibility of More Options menu button #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aarjava wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🎨 Palette: Improve accessibility of More Options menu button #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9ff01d
feat(a11y): add aria attributes to More Options menu button
google-labs-jules[bot] Jun 20, 2026
a551cef
feat(a11y): add aria attributes to More Options menu button
google-labs-jules[bot] Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-06-20 - Adding ARIA attributes to Toggle Menu Buttons
**Learning:** Found that custom UI action menus without built-in accessibility features (`aria-expanded`, `aria-haspopup`) are common for "More Options" (`MoreHorizontal` icon) triggers in the codebase, reducing screen-reader discoverability for crucial context menus.
**Action:** When inspecting list-item action bars, specifically check for `aria-expanded` and `aria-haspopup` on the trigger buttons to ensure screen readers correctly interpret them as menus and announce their open/closed state.
5 changes: 4 additions & 1 deletion src/components/events/EventAnnotations.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,8 +325,11 @@ export default function EventAnnotations({
setShowActionsFor(showActionsFor === thread.id ? null : thread.id)
}
className="rounded-lg p-1.5 text-[#9CA3AF] hover:bg-[#F8FAFC] hover:text-[#666666] transition-colors"
aria-label="More actions"
aria-expanded={showActionsFor === thread.id}
aria-haspopup="menu"
>
<MoreHorizontal className="size-4" />
<MoreHorizontal className="size-4" aria-hidden="true" />
</button>

<AnimatePresence>
Expand Down
Loading