Fix duplicate "fixed by" packages in PackageDetails view #2097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves aboutcode-org#1907 Added deduplication logic using seen_packages dictionary to prevent duplicate entries when multiple ImpactedPackage records reference the same fixing package. Signed-off-by: Mrityunjay Raj <mr.raj.earth@gmail.com>
mr-raj12
force-pushed
the
fix-1907-duplicate-fixed-by
branch
from
5f31f12 to
67b57a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
seen_packagesdictionary to track package IDs per advisoryImpactedPackagerecords reference the same fixing packageResolves #1907
Changes
File:
vulnerabilities/views.py(lines 223-242)Before: Used
.extend()without checking for duplicatesAfter: Track seen package IDs per advisory and only add unique packages
Test Plan
Signed-off-by: Mrityunjay Raj mr.raj.earth@gmail.com