Skip to content

Fix duplicate "fixed by" packages in PackageDetails view #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mr-raj12 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix duplicate "fixed by" packages in PackageDetails view #2097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions vulnerabilities/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ def get_fixed_package_details(self, package):
advisory_by_avid = {adv.avid: adv for adv in latest_advisories}

fixed_pkg_details = {}
seen_packages = {} # Track seen package IDs per avid to avoid duplicates

for impact in affected_impacts:
avid = impact.advisory.avid
Expand All @@ -229,15 +230,16 @@ def get_fixed_package_details(self, package):
continue
if avid not in fixed_pkg_details:
fixed_pkg_details[avid] = []
fixed_pkg_details[avid].extend(
[
{
"pkg": pkg,
"affected_count": pkg.affected_in_impacts.count(),
}
for pkg in impact.fixed_by_packages.all()
]
)
seen_packages[avid] = set()
for pkg in impact.fixed_by_packages.all():
if pkg.id not in seen_packages[avid]:
seen_packages[avid].add(pkg.id)
fixed_pkg_details[avid].append(
{
"pkg": pkg,
"affected_count": pkg.affected_in_impacts.count(),
}
)

affected_by_advisories = {
advisory_by_avid[avid] for avid in affected_avids if avid in advisory_by_avid
Expand Down