Missile Defense - New Component - #10965
Open
BrettMayson wants to merge 22 commits into
Open
Conversation
BrettMayson
commented
Jun 17, 2025
TheCandianVendingMachine
requested changes
Jun 17, 2025
TheCandianVendingMachine
left a comment
TheCandianVendingMachine
left a comment
Contributor
There was a problem hiding this comment.
initial pass, not super thorough. I'm going to close the other PR, I like this more in every way (especially naming given recent events...)
PabstMirror
reviewed
Jun 21, 2025
m1kesk
reviewed
Jun 29, 2025
veteran29
requested changes
Sep 14, 2025
PabstMirror
reviewed
Sep 21, 2025
Co-authored-by: Filip Maciejewski <veteran29@users.noreply.github.com> Co-authored-by: PabstMirror <pabstmirror@gmail.com>
SpicyBagpipes
suggested changes
Feb 6, 2026
SpicyBagpipes
suggested changes
Mar 1, 2026
SpicyBagpipes
left a comment
SpicyBagpipes
left a comment
Contributor
There was a problem hiding this comment.
I'm daft and couldn't figure out how to PR the branch on GitHub desktop so have a review instead
Co-Authored-By: SpicyBagpipes <spicybagpipes@gmail.com>
BrettMayson
requested review from
PabstMirror,
TheCandianVendingMachine and
veteran29
March 20, 2026 20:59
PabstMirror
requested changes
May 12, 2026
PabstMirror
reviewed
May 12, 2026
| _launcher setVariable [QGVAR(state), LAUNCH_STATE_COOLDOWN]; | ||
| _launcher setVariable [QGVAR(lastLaunchTime), CBA_missionTime]; | ||
| private _turret = [_launcher, (crew _launcher) select 0] call CBA_fnc_turretPath; | ||
| [_launcher, _launcher currentWeaponTurret _turret] call BIS_fnc_fire; |
Contributor
There was a problem hiding this comment.
this func gave me a lot of trouble
[q1,"ace_missile_manpad_rim116"] call bis_fnc_fire seems to have no effect sometimes
forceWeaponFire seemed to be more reliable but we'd also need to handle locality issues
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
PabstMirror
reviewed
Jul 26, 2026
| @@ -0,0 +1,3 @@ | |||
| #include "script_component.hpp" | |||
|
|
|||
| GVAR(destroyRadius) = 20; | |||
Contributor
There was a problem hiding this comment.
seems to be used in QGVAR(destroyProjectile) which is global
so should just be in XEH_preInit or will be undefined on dedicated, (I think)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
https://www.youtube.com/watch?v=H-JSDWOMnXY
This meets my needs and if big changes are wanted someone will have to take over. I still didn't use a CBA state machine just because I wanted to do this quick and I don't know them.
Could maybe use some additional customization and functionality (specifying projectile classes to intercept, only fire on projectiles that will hit in a certain area?)
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.