[MWPW-189268] Add Nala E2E tests for Floodgate for DA#5912
Merged
milo-pr-merge[bot] merged 1 commit intoMay 13, 2026
Conversation
021502c to
bedafa8
Compare
Dli3
approved these changes
May 8, 2026
skumar09
reviewed
May 9, 2026
Contributor
There was a problem hiding this comment.
@JackySun9 we need to remove these test execution from every PR?
cc: @narcis-radu , @SilviuLCF
bedafa8 to
3df2eea
Compare
Adds comprehensive end-to-end test coverage for the Floodgate for DA tool (MWPW-189268) running against da.live with the da-floodgate branch. What's included: - Page Object Model with iframe + shadow DOM traversal (floodgate.page.js) - 51 test cases across 7 suites: Page Load, Path Validation, Copy (Simple + Real Events), Content Integrity, Promote, Delete, Cancel/Retry, E2E Smoke Chain - Real-content seed script that pulls 5 production event pages + their fragments into a sandbox at /drafts/nala-fg-test/ - DA login helper that saves a Playwright storageState for test reuse - Self-healing test data hooks via DA admin API (ensureFileInFg) so delete tests don't break each other - Byte-level source-vs-FG content comparator that normalizes URL rewrites and verifies CaaS-encoded payload preservation - Full English TEST-PLAN.md with execution instructions and risk register Test execution: - 51 tests, 49 pass, 2 intentional skips, 0 failures - ~7 min runtime at workers=1 - Verified Bugs #1 (runtime fragment discovery) and #2 (.link file handling) are now fixed in the da-floodgate branch Auth setup: - Run `node nala/utils/da-login.js` once to create auth.json (gitignored) - Tests reuse the storageState; no credentials in code Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3df2eea to
9ceb481
Compare
Contributor
|
This PR does not qualify for the zero-impact label as it touches code outside of the allowed areas. The label is auto applied, do not manually apply the label. |
skumar09
approved these changes
May 12, 2026
Contributor
skumar09
left a comment
There was a problem hiding this comment.
- As discussed in the offline Slack chat, thanks for updating the path features/dafloodgate/** to the ignore list so that Floodgate tests are not triggered on PR push/commit commands.
- removing the do-not-merge label
cc: @narcis-radu , @SilviuLCF , @mokimo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive Nala end-to-end test coverage for the Floodgate for DA tool (
MWPW-189268), running againstda.livewith theda-floodgatebranch./drafts/nala-fg-test/sandboxensureFileInFg) so delete tests recover from prior-test state changesTest Architecture
nala/utils/da-login.jsauth.jsonstorageStatenala/features/dafloodgate/floodgate.page.jsnala/features/dafloodgate/floodgate.spec.jsnala/features/dafloodgate/floodgate.test.jsnala/features/dafloodgate/seed-real-content.jsnala/features/dafloodgate/setup-test-data.jsnala/features/dafloodgate/TEST-PLAN.mdBugs Surfaced & Fixed (pre-GA)
This test suite caught 2 product bugs which were subsequently fixed on the
da-floodgatebranch:chrono-boxdynamic paths missed by Find step).linkfiles silently skipped (not inSUPPORTED_FILES)Both are verified fixed in the latest test run.
How to Run
Notes
--workers=1; parallel execution causes race conditions on shared FG repo state.auth.jsonis gitignored — each contributor runsda-login.jsonce locally./adobecom/da-events/drafts/nala-fg-test/https://da.live/#/adobecom/da-events/tools/floodgate?ref=da-floodgateTest plan
🤖 Generated with Claude Code