You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
adds amd-skill-finder as a native cross-cutting AMD catalog skill
searches installed skills and the published AMD catalog before routing to source repositories
adds a curated registry covering official AMD/ROCm projects and reviewed ecosystem projects
keeps general GitHub discovery opt-in and distinguishes installable skills from source material
publishes the new skill through the Claude, Codex, Cursor, and agents manifests
Why
AMD's catalog needs a stable capability detector similar to NVIDIA's skill finder,
while also covering AMD-specific knowledge that currently lives in ROCm and selected
upstream repositories rather than packaged skills.
The finder uses this trust order:
installed skills
published amd/skills catalog entries
official AMD, ROCm, and AMD-AGI repositories
reviewed upstream repositories
unreviewed GitHub fallback only when explicitly enabled
Repositories remain non-installable source results unless they are published as
validated AMD catalog skills. PyTorch, JAX, and Triton AMD forks are grouped with
their upstream repositories instead of producing duplicate recommendations.
The registry includes MORI, Hyperloom, PyTorch, JAX, Triton, TorchTitan, LMCache,
Mooncake, TileLang, NIXL, Miles, VERL, VIME, vLLM, SGLang, AITER, ATOM, and related
ROCm sources. ai-dynamo/dynamo is explicitly excluded; the separately requested ai-dynamo/nixl source remains included.
uvx --system-certs ruff format --check ... for finder Python
git diff --check origin/main...HEAD
Behavioral agent eval definitions are included under skills/amd-skill-finder/evals/.
Fork PR jobs cannot access AMD's ORCHESTR_API_KEY; an AMD maintainer can rerun the
required behavioral gate from a trusted context.
This PR now contains only amd-skill-finder. The Quark skill family is submitted
independently in #122, as requested in the review discussion.
This is a useful skill — it turns "look for an existing skill first" into an explicit path. We are on the AMD Quark team and have been reading the finder end to end while working out how Quark's own skills should join the catalog. From that angle there is one thing we would like to raise, only so that the quantization path actually gets walked:
Neither the description nor amd_signals carries any quantization vocabulary. The frontmatter trigger list names vLLM, SGLang, AITER, MORI, TileLang and a dozen other projects, but never Quark, quantization, or any precision format; amd_signals likewise has no quark, so a Quark-only question misses the +8 that score_project gives AMD-official sources. The Quark entry in data/sources.json is already thorough, but it is hard to reach on exactly those queries. Suggest adding Quark and the quantization vocabulary to both the description and amd_signals, plus a deterministic routing test as the policy document itself requires — Quark is currently absent from the 13 projects asserted in test_requested_projects_and_canonical_repositories_are_present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
amd-skill-finderas a native cross-cutting AMD catalog skillWhy
AMD's catalog needs a stable capability detector similar to NVIDIA's skill finder,
while also covering AMD-specific knowledge that currently lives in ROCm and selected
upstream repositories rather than packaged skills.
The finder uses this trust order:
amd/skillscatalog entriesRepositories remain non-installable source results unless they are published as
validated AMD catalog skills. PyTorch, JAX, and Triton AMD forks are grouped with
their upstream repositories instead of producing duplicate recommendations.
The registry includes MORI, Hyperloom, PyTorch, JAX, Triton, TorchTitan, LMCache,
Mooncake, TileLang, NIXL, Miles, VERL, VIME, vLLM, SGLang, AITER, ATOM, and related
ROCm sources.
ai-dynamo/dynamois explicitly excluded; the separately requestedai-dynamo/nixlsource remains included.Validation
UV_SYSTEM_CERTS=true bash .github/scripts/check.shpython3 -m unittest skills/amd-skill-finder/tests/test_find_skills.py(15 tests)uvx --system-certs ruff check skills/amd-skill-finderuvx --system-certs ruff format --check ...for finder Pythongit diff --check origin/main...HEADBehavioral agent eval definitions are included under
skills/amd-skill-finder/evals/.Fork PR jobs cannot access AMD's
ORCHESTR_API_KEY; an AMD maintainer can rerun therequired behavioral gate from a trusted context.
This PR now contains only
amd-skill-finder. The Quark skill family is submittedindependently in #122, as requested in the review discussion.