You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current branch implements the earlier 17-skill wrapper-resolution approach. That design is
superseded and should not be merged or used as the basis for further catalog-specific Quark logic.
Source-owned, self-contained entry points are now proposed in amd/Quark#38:
quark-install
quark-torch-ptq
quark-onnx-ptq
This PR will remain a draft and paused until the Quark maintainers accept the source-side path and
entry-point boundaries. After that prerequisite lands, this branch will be rewritten so its final
diff contains only generic federation work:
source declarations for the accepted Quark folders and pinned ref
unchanged imported skill packages and generated catalog manifests
generic importer/validation behavior already used by other source-owned skills
The final revision will remove the Quark-specific wrapper resolver, internal skill-name coupling,
hard-coded public-skill count, helper bundling/rewrites, and Quark-specific federation audit.
No catalog rewrite is being pushed yet because doing so before the source PR is reviewed would pin
an unaccepted folder/API contract and create avoidable churn.
Thanks for taking on the work of bringing Quark's skills into the catalog — this is something we have wanted to see happen. We are on the Quark team, and having read through it there is one structural concern we would like to raise:
This integration writes Quark's internal layout, the v0.12 version and a set of internal skill names into the catalog's own importer and CI, which couples the two tightly: anything that moves on the Quark side means redoing the work here.
A safer shape would follow magpie-kernel-evaluator and tracelens-analysis-orchestrator: the source repository maintains a small number of self-contained entry-point skills, sources.yml declares only the repo, the ref and the folder names, the importer copies them as they are, and the catalog carries no product-specific logic.
Agreed. I have moved the packaging boundary to Quark and opened amd/Quark#38 with three self-contained, source-owned entry points: quark-install, quark-torch-ptq, and quark-onnx-ptq. They do not reference Quark’s internal .claude graph and can be copied unchanged by the catalog’s generic importer. I have marked this draft paused; after the source PR is accepted, I will rewrite this branch to generic source declarations/imported outputs only and remove the Quark-specific resolver, internal-name/version assertions, helper bundling, and product-specific audit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: paused on the Quark source PR
The current branch implements the earlier 17-skill wrapper-resolution approach. That design is
superseded and should not be merged or used as the basis for further catalog-specific Quark logic.
Source-owned, self-contained entry points are now proposed in amd/Quark#38:
quark-installquark-torch-ptqquark-onnx-ptqThis PR will remain a draft and paused until the Quark maintainers accept the source-side path and
entry-point boundaries. After that prerequisite lands, this branch will be rewritten so its final
diff contains only generic federation work:
The final revision will remove the Quark-specific wrapper resolver, internal skill-name coupling,
hard-coded public-skill count, helper bundling/rewrites, and Quark-specific federation audit.
Relationship to other work
amd-skill-finder#119 independently addsamd-skill-finder; it is not part of this PR.No catalog rewrite is being pushed yet because doing so before the source PR is reviewed would pin
an unaccepted folder/API contract and create avoidable churn.