Skip to content

Add federated AMD Quark skill family - #122

Draft
andyluo7 wants to merge 2 commits into
amd:mainfrom
andyluo7:codex/quark-skills
Draft

Add federated AMD Quark skill family#122
andyluo7 wants to merge 2 commits into
amd:mainfrom
andyluo7:codex/quark-skills

Conversation

@andyluo7

@andyluo7 andyluo7 commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Status: paused on the Quark source PR

The current branch implements the earlier 17-skill wrapper-resolution approach. That design is
superseded and should not be merged or used as the basis for further catalog-specific Quark logic.

Source-owned, self-contained entry points are now proposed in amd/Quark#38:

  • quark-install
  • quark-torch-ptq
  • quark-onnx-ptq

This PR will remain a draft and paused until the Quark maintainers accept the source-side path and
entry-point boundaries. After that prerequisite lands, this branch will be rewritten so its final
diff contains only generic federation work:

  • source declarations for the accepted Quark folders and pinned ref
  • unchanged imported skill packages and generated catalog manifests
  • generic importer/validation behavior already used by other source-owned skills

The final revision will remove the Quark-specific wrapper resolver, internal skill-name coupling,
hard-coded public-skill count, helper bundling/rewrites, and Quark-specific federation audit.

Relationship to other work

No catalog rewrite is being pushed yet because doing so before the source PR is reviewed would pin
an unaccepted folder/API contract and create avoidable churn.

@amd-zhaofeng

Copy link
Copy Markdown

Thanks for taking on the work of bringing Quark's skills into the catalog — this is something we have wanted to see happen. We are on the Quark team, and having read through it there is one structural concern we would like to raise:

This integration writes Quark's internal layout, the v0.12 version and a set of internal skill names into the catalog's own importer and CI, which couples the two tightly: anything that moves on the Quark side means redoing the work here.

A safer shape would follow magpie-kernel-evaluator and tracelens-analysis-orchestrator: the source repository maintains a small number of self-contained entry-point skills, sources.yml declares only the repo, the ref and the folder names, the importer copies them as they are, and the catalog carries no product-specific logic.

@andyluo7

andyluo7 commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator Author

Agreed. I have moved the packaging boundary to Quark and opened amd/Quark#38 with three self-contained, source-owned entry points: quark-install, quark-torch-ptq, and quark-onnx-ptq. They do not reference Quark’s internal .claude graph and can be copied unchanged by the catalog’s generic importer. I have marked this draft paused; after the source PR is accepted, I will rewrite this branch to generic source declarations/imported outputs only and remove the Quark-specific resolver, internal-name/version assertions, helper bundling, and product-specific audit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants