[hotfix][runtime-web] Bring logs components under eslint enforcement

[spuru9]

What is the purpose of the change

.eslintignore has a bare logs pattern that uses gitignore semantics — it matches a directory of that name at any depth. It was meant for a top-level log-output directory but also captures src/app/pages/{job-manager,task-manager}/logs/, the source dirs holding the dashboard's log pages. Files under those paths were silently skipped by lint-staged, CI, and IDE eslint.

Brief change log

• Anchor the pattern at the project root: logs -> /logs.
• Run eslint --fix on both *-logs.component.ts files (prettier whitespace/quotes/brackets, import/order, import deduplication).
• Add : void return types to ngOnInit and reload in both components (@typescript-eslint/explicit-function-return-type is not auto-fixable).

Verifying this change

cd flink-runtime-web/web-dashboard
rm -f .eslintcache
npm run lint   # exits 0; both files are now included by eslint

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): no
• The public API, i.e., is any changed class annotated with @Public(Evolving): no
• The serializers: no
• The runtime per-record code paths (performance sensitive): no
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
• The S3 file system connector: no

Documentation

• Does this pull request introduce a new feature? no
• If yes, how is the feature documented? not applicable

---

Was generative AI tooling used to co-author this PR?

• Yes (Claude Code / Claude Opus 4.7)

Generated-by: Claude Code (Claude Opus 4.7)

[flinkbot]

CI report:

• 6b0b160 Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[spuru9]

@featzhang Can you review this hotfix. Related to the one I commented about, have made the fix so it don't come up in future PRs.

[featzhang]

Thanks for tracking this down — the root-cause analysis is spot on. The bare logs pattern has been there since 2021 (6f03f02), so two real source dirs (src/app/pages/{job-manager,task-manager}/logs/) have been silently excluded from lint for years, which is exactly how prettier drift accumulated on those two files and later leaked into an unrelated feature PR as reformat noise.

The fix is minimal and well-scoped: the logs → /logs anchoring keeps the original intent (ignoring a top-level runtime log dir) without shadowing source paths, and the accompanying eslint --fix output plus the : void return types are consistent with how the rest of the codebase is written — ngOnDestroy(): void in the same files was already annotated, and every other public ngOnInit under src/app/pages uses : void, so these two files are simply being brought into line rather than introducing a new style.

Verified locally that the diff contains no behavioral changes — only import reordering/deduplication, quote/bracket normalization, indentation, and the four : void annotations. +1 from me.

One follow-up thought (non-blocking): the same bare-pattern issue also applies to tsc-out and dist on lines 4–5 of .eslintignore. There are no source dirs with those names today, but the pattern is the same footgun. Could be tightened in the same spirit (/tsc-out, /dist) either here or as a small separate hotfix.

[spuru9]

@featzhang Have addressed the comment. Can you review/approve.