Skip to content

[hotfix][runtime-web] Bring logs components under eslint enforcement #28086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spuru9 wants to merge 2 commits into
base: master
Choose a base branch
from
+35 −39
Open

[hotfix][runtime-web] Bring logs components under eslint enforcement #28086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
569255d
[hotfix][runtime-web] Bring *-logs components under eslint enforcement
spuru9 May 1, 2026
6b0b160
[hotfix][runtime-web] Anchor remaining .eslintignore artifact dirs
spuru9 May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions flink-runtime-web/web-dashboard/.eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
.idea
gen
web
tsc-out
dist
/tsc-out
/dist

# Logs
logs
/logs
*.log
npm-debug.log*

Expand Down
32 changes: 15 additions & 17 deletions flink-runtime-web/web-dashboard/src/app/pages/job-manager/logs/job-manager-logs.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,29 +17,27 @@
*/

import { ChangeDetectorRef, Component, OnInit, ChangeDetectionStrategy, OnDestroy, Inject } from '@angular/core';
import { ConfigService, JobManagerService } from '@flink-runtime-web/services';
import { EditorOptions } from 'ng-zorro-antd/code-editor';
import { FormsModule } from '@angular/forms';
import { of, Subject } from 'rxjs';
import { catchError, takeUntil } from 'rxjs/operators';

import { AddonCompactComponent } from '@flink-runtime-web/components/addon-compact/addon-compact.component';
import { AutoResizeDirective } from '@flink-runtime-web/components/editor/auto-resize.directive';
import { flinkEditorOptions } from '@flink-runtime-web/components/editor/editor-config';
import {of, Subject} from 'rxjs';
import {catchError, takeUntil} from 'rxjs/operators';
import {
JOB_MANAGER_MODULE_CONFIG,
JOB_MANAGER_MODULE_DEFAULT_CONFIG,
JobManagerModuleConfig
} from '@flink-runtime-web/pages/job-manager/job-manager.config';
import {NzCodeEditorModule} from "ng-zorro-antd/code-editor";
import {AutoResizeDirective} from "@flink-runtime-web/components/editor/auto-resize.directive";
import {FormsModule} from "@angular/forms";
import {
AddonCompactComponent
} from "@flink-runtime-web/components/addon-compact/addon-compact.component";
import { ConfigService, JobManagerService } from '@flink-runtime-web/services';
import { EditorOptions, NzCodeEditorModule } from 'ng-zorro-antd/code-editor';

@Component({
selector: 'flink-job-manager-logs',
templateUrl: './job-manager-logs.component.html',
styleUrls: ['./job-manager-logs.component.less'],
changeDetection: ChangeDetectionStrategy.OnPush,
imports: [NzCodeEditorModule, AutoResizeDirective, FormsModule, AddonCompactComponent]
selector: 'flink-job-manager-logs',
templateUrl: './job-manager-logs.component.html',
styleUrls: ['./job-manager-logs.component.less'],
changeDetection: ChangeDetectionStrategy.OnPush,
imports: [NzCodeEditorModule, AutoResizeDirective, FormsModule, AddonCompactComponent]
})
export class JobManagerLogsComponent implements OnInit, OnDestroy {
public readonly downloadName = `jobmanager_log`;
Expand All @@ -60,7 +58,7 @@ export class JobManagerLogsComponent implements OnInit, OnDestroy {
this.downloadUrl = `${this.configService.BASE_URL}/jobmanager/log`;
}

public ngOnInit() {
public ngOnInit(): void {
this.reload();
}

Expand All @@ -69,7 +67,7 @@ export class JobManagerLogsComponent implements OnInit, OnDestroy {
this.destroy$.complete();
}

public reload() {
public reload(): void {
this.loading = true;
this.cdr.markForCheck();
this.jobManagerService
Expand Down
36 changes: 17 additions & 19 deletions ...-runtime-web/web-dashboard/src/app/pages/task-manager/logs/task-manager-logs.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,29 +17,27 @@
*/

import { ChangeDetectorRef, Component, OnInit, ChangeDetectionStrategy, OnDestroy, Inject } from '@angular/core';
import {catchError, takeUntil} from 'rxjs/operators';
import { ConfigService, TaskManagerService } from '@flink-runtime-web/services';
import { EditorOptions } from 'ng-zorro-antd/code-editor';
import {of, Subject} from 'rxjs';
import { FormsModule } from '@angular/forms';
import { ActivatedRoute } from '@angular/router';
import { of, Subject } from 'rxjs';
import { catchError, takeUntil } from 'rxjs/operators';

import { AddonCompactComponent } from '@flink-runtime-web/components/addon-compact/addon-compact.component';
import { AutoResizeDirective } from '@flink-runtime-web/components/editor/auto-resize.directive';
import { ModuleConfig } from '@flink-runtime-web/core/module-config';
import {
TASK_MANAGER_MODULE_CONFIG,
TASK_MANAGER_MODULE_DEFAULT_CONFIG,
TASK_MANAGER_MODULE_DEFAULT_CONFIG
} from '@flink-runtime-web/pages/task-manager/task-manager.config';
import {ModuleConfig} from "@flink-runtime-web/core/module-config";
import {NzCodeEditorModule} from "ng-zorro-antd/code-editor";
import {AutoResizeDirective} from "@flink-runtime-web/components/editor/auto-resize.directive";
import {FormsModule} from "@angular/forms";
import {
AddonCompactComponent
} from "@flink-runtime-web/components/addon-compact/addon-compact.component";
import { ConfigService, TaskManagerService } from '@flink-runtime-web/services';
import { EditorOptions, NzCodeEditorModule } from 'ng-zorro-antd/code-editor';

@Component({
selector: 'flink-task-manager-logs',
templateUrl: './task-manager-logs.component.html',
styleUrls: ['./task-manager-logs.component.less'],
changeDetection: ChangeDetectionStrategy.OnPush,
imports: [NzCodeEditorModule, AutoResizeDirective, FormsModule, AddonCompactComponent]
selector: 'flink-task-manager-logs',
templateUrl: './task-manager-logs.component.html',
styleUrls: ['./task-manager-logs.component.less'],
changeDetection: ChangeDetectionStrategy.OnPush,
imports: [NzCodeEditorModule, AutoResizeDirective, FormsModule, AddonCompactComponent]
})
export class TaskManagerLogsComponent implements OnInit, OnDestroy {
public editorOptions: EditorOptions;
Expand All @@ -61,7 +59,7 @@ export class TaskManagerLogsComponent implements OnInit, OnDestroy {
this.editorOptions = moduleConfig.editorOptions || TASK_MANAGER_MODULE_DEFAULT_CONFIG.editorOptions;
}

public ngOnInit() {
public ngOnInit(): void {
this.taskManagerId = this.activatedRoute.parent!.snapshot.params.taskManagerId;
this.downloadUrl = `${this.configService.BASE_URL}/taskmanagers/${this.taskManagerId}/log`;
this.downloadName = `taskmanager_${this.taskManagerId}_log`;
Expand All @@ -73,7 +71,7 @@ export class TaskManagerLogsComponent implements OnInit, OnDestroy {
this.destroy$.complete();
}

public reload() {
public reload(): void {
this.loading = true;
this.cdr.markForCheck();
this.taskManagerService
Expand Down