YARN-11964: Resource.castToIntSafely() should clamp negative values to 0#8506
Open
ryukobayashi wants to merge 1 commit into
Open
YARN-11964: Resource.castToIntSafely() should clamp negative values to 0#8506ryukobayashi wants to merge 1 commit into
ryukobayashi wants to merge 1 commit into
Conversation
Negative resource values returned by YARN RM (e.g. due to transient overload or node failures) were passed through castToIntSafely() without any guard, propagating invalid negative ints to downstream components. Add a guard that clamps values below 0 to 0, consistent with the existing upper-bound clamp to Integer.MAX_VALUE.
|
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Resource.castToIntSafely() only guarded against positive overflow (clamping values > Integer.MAX_VALUE to Integer.MAX_VALUE), but passed negative values through unchanged. The method's Javadoc stated "This method assumes resource value is positive", however YARN RM can transiently return negative available resources (e.g. due to overload or node failures), violating this assumption.
This patch adds a guard that clamps values below 0 to 0, consistent with the existing upper-bound clamping behavior.
How was this patch tested?
Existing unit tests in TestResource pass.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
If an AI tool was used: