Skip to content

YARN-11964: Resource.castToIntSafely() should clamp negative values to 0 #8506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steveloughran merged 2 commits into from
May 26, 2026
+11 −2
Merged

YARN-11964: Resource.castToIntSafely() should clamp negative values to 0 #8506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba97cc7
YARN-11964: Resource.castToIntSafely() should clamp negative values to 0
ryukobayashi May 20, 2026
d8ac086
YARN-11964: Resource.castToIntSafely() should clamp negative values to 0
ryukobayashi May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...adoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/Resource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,13 +513,17 @@ public int hashCode() {
}

/**
* Convert long to int for a resource value safely. This method assumes
* resource value is positive.
* Convert long to int for a resource value safely. Negative values are
* clamped to 0; values exceeding Integer.MAX_VALUE are clamped to
* Integer.MAX_VALUE.
*
* @param value long resource value
* @return int resource value
*/
protected static int castToIntSafely(long value) {
if (value < 0) {
return 0;
}
if (value > Integer.MAX_VALUE) {
return Integer.MAX_VALUE;
}
Expand Down
5 changes: 5 additions & 0 deletions ...p-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/api/records/TestResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,11 @@ void testCastToIntSafely() {
Resource.castToIntSafely(Long.MAX_VALUE),
"Cast to Integer.MAX_VALUE if the long is greater than "
+ "Integer.MAX_VALUE");

assertEquals(0, Resource.castToIntSafely(-1),
Copy link
Copy Markdown
Contributor

@steveloughran steveloughran May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keeping with assertEquals as it's already in use...FYI for new test suites we like AssertJ as it's more informative and cherrypicks easily from junit5 branches (3.5+) and Junit4 (3.4.x)

Copy link
Copy Markdown
Contributor Author

@ryukobayashi ryukobayashi May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the information!

"Cast to 0 if the long is negative");
assertEquals(0, Resource.castToIntSafely(Long.MIN_VALUE),
"Cast to 0 if the long is negative");
}

@Test
Expand Down
Loading