feat!(catalog): adding support for purge_table#2232
Open
CTTY wants to merge 12 commits intoapache:mainfrom
Open
feat!(catalog): adding support for purge_table#2232CTTY wants to merge 12 commits intoapache:mainfrom
CTTY wants to merge 12 commits intoapache:mainfrom
Conversation
CTTY
commented
Mar 12, 2026
geruh
reviewed
Mar 14, 2026
CTTY
changed the title
blackmwk
reviewed
Mar 24, 2026
geruh
reviewed
Mar 24, 2026
| async fn drop_table(&self, table: &TableIdent) -> Result<()> { | ||
| /// S3 Tables doesn't support soft delete, so dropping a table will permanently remove it from the catalog. | ||
| async fn drop_table(&self, _table: &TableIdent) -> Result<()> { | ||
| Err(Error::new( |
Member
There was a problem hiding this comment.
| harness.label | ||
| )); | ||
|
|
||
| cleanup_namespace_dyn(catalog.as_ref(), &namespace).await; |
Member
There was a problem hiding this comment.
Just a heads up but, looks like cleanup_namespace_dyn calls drop_table, and with the new logic from S3Tables we would get the unsupported exception. The error gets swallowed, but worth running with the S3Tables creds to make sure. Might also be worth switching cleanup to use purge instead.
Collaborator
Author
There was a problem hiding this comment.
Good catch! I think switching to use purge makes sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Catalog#2133What changes are included in this PR?
purge_tabletoCatalogtrait and add default implementationAre these changes tested?
Added new tests in table_suite