-
Notifications
You must be signed in to change notification settings - Fork 440
feat!(catalog): adding support for purge_table #2232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+337
−29
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d15deeb
adding support for purge_table
CTTY 642ccdc
Merge branch 'main' into ctty/purge-table
CTTY c79238d
improve
CTTY d85c922
expose error correctly
CTTY 31b4310
add default purge implementation
CTTY 06ee8f6
revert unneeded changes
CTTY 68e217a
implement purge for rest
CTTY a98a55b
add purge_table tests
CTTY ce27668
optimize concurrency, remove default impl for purge_table
CTTY 5d24a41
minor
CTTY 8cc843c
fail s3table::drop_table
CTTY ee20b38
fmt
CTTY 43ad3fa
use purge_table instead to cleanup
CTTY ab216f7
Merge branch 'main' into ctty/purge-table
CTTY File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -562,15 +562,18 @@ impl Catalog for S3TablesCatalog { | |
| Ok(self.load_table_with_version_token(table_ident).await?.0) | ||
| } | ||
|
|
||
| /// Drops an existing table from the s3tables catalog. | ||
| /// Not supported for S3Tables. Use `purge_table` instead. | ||
| /// | ||
| /// Validates the table identifier and then deletes the corresponding | ||
| /// table from the s3tables catalog. | ||
| /// | ||
| /// This function can return an error in the following situations: | ||
| /// - Errors from the underlying database deletion process, converted using | ||
| /// `from_aws_sdk_error`. | ||
| async fn drop_table(&self, table: &TableIdent) -> Result<()> { | ||
| /// S3 Tables doesn't support soft delete, so dropping a table will permanently remove it from the catalog. | ||
| async fn drop_table(&self, _table: &TableIdent) -> Result<()> { | ||
| Err(Error::new( | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| ErrorKind::FeatureUnsupported, | ||
| "drop_table is not supported for S3Tables; use purge_table instead", | ||
| )) | ||
| } | ||
|
|
||
| /// Purge a table from the S3 Tables catalog. | ||
| async fn purge_table(&self, table: &TableIdent) -> Result<()> { | ||
| let req = self | ||
| .s3tables_client | ||
| .delete_table() | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.