Open API: Fix LICENSE and NOTICE files#15872
Conversation
manuzhang
force-pushed
the
open-api-license-notice-align
branch
from
3cc9d2c to
28b3071
Compare
manuzhang
changed the title
Co-authored-by: OpenAI Codex <noreply@openai.com>
manuzhang
force-pushed
the
open-api-license-notice-align
branch
from
28b3071 to
ba60dbe
Compare
|
Just a note we shouldn't need everything I listed in that issue now that Ryan has removed the Aliyun transitives. We'll probably want to re check everything again |
|
@RussellSpitzer Yeah, I just rebased, rebuilt and asked Codex to check LICENSE file against the runtime jar. |
|
@manuzhang thanks for the heads up. I'm doing a pass. |
jbonofre
left a comment
jbonofre
left a comment
There was a problem hiding this comment.
I see some dependencies packaged in iceberg-open-api-test-fixtures-runtime but not in LICENSE:
- Bouncy Castle
- Nimbus JWT
- JCIP (shaded in Nimbus)
- Android Annotations
- Jakarta Servlet (in addition of javax.servlet).
@manuzhang can you please double check ?
open-api/NOTICE
Outdated
|
|
||
| -------------------------------------------------------------------------------- | ||
|
|
||
| This product bundles Apache Parquet Format with the following in its NOTICE file: |
There was a problem hiding this comment.
As the NOTICE file already contains:
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/)
it's not strictly required to have the ASF NOTICE (or with special reasons).
It doesn't hurt to keep it, but maybe something to consider as follow up.
Generally speaking, we should keep NOTICE file as simple as possible.
There was a problem hiding this comment.
I've removed all ASF projects' notices except for Apache Hadoop, which includes a section on export control.
|
@jbonofre Thanks for the review. I'm not sure how Bouncy Castle's license should be included. Same as MIT? |
|
|
||
| Project URL: https://www.bouncycastle.org/java.html | ||
| License: MIT - https://www.bouncycastle.org/about/license/ | ||
| LICENSE |
There was a problem hiding this comment.
The following is copied from their website and it's claimed
Bouncy Castle APIs are released under the MIT license. Please note LICENSE should be read in the same way as the MIT license.
3 participants
Align LICENSE and NOTICE files with changes in #15449.
@codex also identified some missing licenses and notices.