Skip to content

Fix typo: rename rebuilded() to rebuilt() #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cowwoc wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix typo: rename rebuilded() to rebuilt() #415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fc5d22
Fix typo: rename rebuilded() to rebuilt()
cowwoc Dec 1, 2025
2a87e76
Address review feedback: remove static import and rename parameter
cowwoc Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@
import static org.apache.maven.buildcache.CacheResult.empty;
import static org.apache.maven.buildcache.CacheResult.failure;
import static org.apache.maven.buildcache.CacheResult.partialSuccess;
import static org.apache.maven.buildcache.CacheResult.rebuilded;
import static org.apache.maven.buildcache.CacheResult.success;
import static org.apache.maven.buildcache.RemoteCacheRepository.BUILDINFO_XML;
import static org.apache.maven.buildcache.checksum.KeyUtils.getVersionlessProjectKey;
Expand Down Expand Up @@ -529,7 +528,7 @@ public void save(
hashFactory.getAlgorithm());
populateGitInfo(build, session);
build.getDto().set_final(cacheConfig.isSaveToRemoteFinal());
cacheResults.put(getVersionlessProjectKey(project), rebuilded(cacheResult, build));
cacheResults.put(getVersionlessProjectKey(project), CacheResult.rebuilt(cacheResult, build));

localCache.beforeSave(context);

Expand Down
14 changes: 11 additions & 3 deletions src/main/java/org/apache/maven/buildcache/CacheResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,18 @@ public static CacheResult failure(CacheContext context) {
return new CacheResult(RestoreStatus.FAILURE, null, context);
}

public static CacheResult rebuilded(CacheResult orig, Build build) {
requireNonNull(orig);
public static CacheResult rebuilt(CacheResult original, Build build) {
requireNonNull(original);
requireNonNull(build);
return new CacheResult(orig.status, build, orig.context);
return new CacheResult(original.status, build, original.context);
}

/**
* @deprecated Use {@link #rebuilt(CacheResult, Build)} instead.
*/
@Deprecated
public static CacheResult rebuilded(CacheResult original, Build build) {
return rebuilt(original, build);
}

public boolean isSuccess() {
Expand Down