Fix typo: rename rebuilded() to rebuilt() #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elharo
requested changes
Dec 3, 2025
cowwoc
force-pushed
the
fix-rebuilded-typo
branch
2 times, most recently
from
d1ceaf4 to
1d84c77
Compare
Corrects the method name to use proper English grammar.
cowwoc
force-pushed
the
fix-rebuilded-typo
branch
from
1d84c77 to
057d35b
Compare
elharo
requested changes
Dec 11, 2025
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java
Outdated
Show resolved
Hide resolved
- Remove static import for rebuilt() method, use qualified CacheResult.rebuilt() instead - Rename parameter 'orig' to 'original' for clarity in both rebuilt() and rebuilded() methods
cowwoc
force-pushed
the
fix-rebuilded-typo
branch
from
057d35b to
2a87e76
Compare
elharo
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CacheResult.rebuilded()method toCacheResult.rebuilt()for correct English grammarContext
This was flagged during review of PR #395 with the comment "not for this PR, but this method name isn't grammatical".