fix: use JSON serialization for array fields in spreadsheet editor #2741

algusarov · 2025-12-25T22:46:44Z

Summary

Replace comma-based join/split with JSON serialization for array fields
Prevents corruption of array items containing commas (JSON, CSV, plain text)
Update placeholder text to reflect JSON array format

Root Cause

The spreadsheet editor used comma-based serialization (value.map(String).join(', ') and stringValue.split(',')) which corrupted any array items containing commas. Simply opening a cell for editing would corrupt in-memory data through two-way binding.

See detailed analysis in #2740.

⚠️ Warning

This is an experimental fix that changes console UX for array-based types.

Users will now need to enter array values in JSON format (e.g., ["item1", "item2"]) instead of comma-separated values. This needs careful review to ensure it doesn't negatively impact the user experience for simpler use cases.

Closes #2740

Summary by CodeRabbit

Improvements
- Array input fields now use JSON array format for better data handling and display
- Updated placeholder guidance for integer, double, boolean, and string array inputs with clear examples of proper JSON formatting syntax
- Enhanced user experience with clearer input format expectations for array-type fields

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Replace comma-based join/split with JSON.stringify/parse to prevent corruption of array items containing commas (JSON, CSV, plain text). Closes appwrite#2740

appwrite · 2025-12-25T22:46:49Z

Console (appwrite/console)

Project ID: 688b7bf400350cbd60e9

Sites (1)

Site	Status	Logs	Preview	QR
console-stage `688b7cf6003b1842c9dc`	Failed	Authorize	Preview URL

Tip

Functions can run for up to 15 minutes before timing out

coderabbitai · 2025-12-25T22:46:58Z

Walkthrough

This pull request modifies the string input component for database table rows to handle array values using JSON format instead of comma-separated strings. Array values are now serialized with JSON.stringify(value, null, 2) and deserialized by attempting to parse the input as JSON. Placeholder texts for array-type inputs (integer, double, boolean, string) have been updated to reflect the new JSON array format requirement. Spatial-type and non-array value handling remain unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~13 minutes

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: switching from comma-based to JSON serialization for array fields.
Linked Issues check	✅ Passed	The pull request fully addresses issue #2740 by replacing comma-based array handling with JSON.stringify/parse, eliminating corruption of JSON string items.
Out of Scope Changes check	✅ Passed	All changes are directly related to fixing the array serialization issue in the spreadsheet editor; no unrelated modifications detected.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e446f7f and 1e37b3f.

📒 Files selected for processing (1)

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/rows/columns/types/string.svelte

🧰 Additional context used

📓 Path-based instructions (5)

**/*.{ts,tsx,js,jsx,svelte}