Skip to content

fix: use JSON serialization for array fields in spreadsheet editor #2741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
algusarov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use JSON serialization for array fields in spreadsheet editor #2741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions ...n]-[project]/databases/database-[database]/table-[table]/rows/columns/types/string.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
if (isSpatialType(column) && Array.isArray(value)) {
stringValue = JSON.stringify(value);
} else if (array && Array.isArray(value)) {
stringValue = value.map(String).join(', ');
stringValue = JSON.stringify(value, null, 2);
} else if (value !== null && value !== undefined) {
stringValue = String(value);
} else {
Expand All @@ -87,12 +87,13 @@

$effect(() => {
if (array) {
const newArray = stringValue
.split(',')
.map((item) => parseValue(item))
.filter((item) => item !== null);
if (JSON.stringify(newArray) !== JSON.stringify(value)) {
value = newArray as string[] | number[] | boolean[];
try {
const parsed = JSON.parse(stringValue);
if (Array.isArray(parsed) && JSON.stringify(parsed) !== JSON.stringify(value)) {
value = parsed;
}
} catch {
// Invalid JSON - don't update value
}
} else {
const parsedValue = isSpatialType(column)
Expand Down Expand Up @@ -120,14 +121,14 @@
} else {
switch (column.type) {
case 'integer':
return 'Enter integers separated by commas';
return 'Enter JSON array, e.g. [1, 2, 3]';
case 'double':
return 'Enter numbers separated by commas';
return 'Enter JSON array, e.g. [1.5, 2.5]';
case 'boolean':
return 'Enter true/false separated by commas';
return 'Enter JSON array, e.g. [true, false]';
case 'string':
default:
return 'Enter strings separated by commas';
return 'Enter JSON array, e.g. ["item1", "item2"]';
}
}
};
Expand Down