Respect Gateway lattice-service-name annotation for service naming #860
+19
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
Which issue does this PR fix:
N/A - No existing issue, but the
lattice-service-nameannotation on Gateway resources is currently ignored by the controller.What does this PR do / Why do we need it:
Adds support for
application-networking.k8s.aws/lattice-service-nameannotation on Gateway resources to control VPC Lattice service naming.Currently, the controller only respects
service-name-overrideon HTTPRoute objects. This PR enables Gateway-level service naming, which is more semantic (Gateway represents the VPC Lattice service) and important for multi-route scenarios and ephemeral environments.If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
Repro:
application-networking.k8s.aws/lattice-service-name: my-service{route-name}-{namespace}instead ofmy-serviceController Logs (before fix):
Results in truncated/duplicated name:
my-route-routes-my-namespaceTesting done on this change:
Manual testing on EKS cluster with Gateway API Controller v1.1.6:
lattice-service-name: my-servicemy-service✓service-name-overridestill takes precedence ✓Before:
After:
Automation added to e2e:
No. If accepted, can add integration tests in follow-up PR.
Will this PR introduce any new dependencies?:
No. Uses existing validation functions (
k8s.ValidateVPCLatticeServiceName,k8s.NewInvalidServiceNameOverrideError) and Gateway lookup (t.findGateway).Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No breaking changes. Purely additive:
service-name-override: Continues to work (highest precedence)lattice-service-name: Now works (new fallback)Tested on running cluster - existing services unaffected, only new/recreated services use Gateway annotation.
Does this PR introduce any user-facing change?:
Yes
Do all end-to-end tests successfully pass when running
make e2e-test?:Not run. Change is minimal (21 lines), uses existing functions, manually tested. Can run e2e if setup guidance provided.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.