Skip to content

Respect Gateway lattice-service-name annotation for service naming #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dlutsch wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Respect Gateway lattice-service-name annotation for service naming #860

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dde2eb
Respect Gateway lattice-service-name annotation for service naming
Dec 5, 2025
69178f9
Use existing service-name-override annotation for Gateway
Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions pkg/gateway/model_build_lattice_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,10 +195,29 @@ func (t *latticeServiceModelBuildTask) buildLatticeService(ctx context.Context)
}
spec.AllowTakeoverFrom = allowTakeoverFrom

// Check for service name override on route first (highest precedence)
serviceNameOverride, err := k8s.GetServiceNameOverrideWithValidation(t.route.K8sObject())
if err != nil {
return nil, err
}

// If not set on route, check the Gateway's service-name-override annotation (fallback)
if serviceNameOverride == "" {
gw, gwErr := t.findGateway(ctx)
if gwErr == nil && gw != nil {
// Use the same validation function as HTTPRoute for consistency
gwServiceNameOverride, gwErr := k8s.GetServiceNameOverrideWithValidation(gw)
if gwErr != nil {
return nil, gwErr
}
if gwServiceNameOverride != "" {
serviceNameOverride = gwServiceNameOverride
t.log.Debugf(ctx, "Using service-name-override from Gateway %s/%s: %s",
gw.GetNamespace(), gw.GetName(), serviceNameOverride)
}
}
}

spec.ServiceNameOverride = serviceNameOverride

svc, err := model.NewLatticeService(t.stack, spec)
Expand Down