Add AWS_CONTAINER_CREDENTIALS_FULL_URI support to EcsCredentialProvider #2249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With reference to using amazon/amazon-ecs-local-container-endpoints for local development and continuing the discussion within PR #48 over there...
When used with docker, the special/static 169.254.170.2 IP requires that a custom network is created and each container is attached to this network and given an IP within this space. This creates significant bloat in docker-compose files which is essentially unnecessary. If we were able to pass in a hostname, it could then be resolved by docker irrespective of any other network configuration. The only configuration then required would be that of the ecs-local-endpoints container.
Description of changes:
By implementing a
AWS_CONTAINER_CREDENTIALS_SERVER_URIenvironmental variable, we are able to pass in an internal hostname to better support the use of Amazon ECS Local Container Endpoints.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.