[PM-33298] Fix InvalidCastException when uploading attachments as admin#7175
Open
boris324 wants to merge 1 commit intobitwarden:mainfrom
Open
[PM-33298] Fix InvalidCastException when uploading attachments as admin#7175boris324 wants to merge 1 commit intobitwarden:mainfrom
boris324 wants to merge 1 commit intobitwarden:mainfrom
Conversation
CipherOrganizationDetails cannot be cast to CipherDetails since CipherDetails is a subclass, not a superclass. Use pattern matching to call the appropriate ReplaceAsync overload based on runtime type. Fixes bitwarden#7062
|
|
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7062
Problem
When uploading attachments via admin endpoints,
GetOrganizationDetailsByIdAsyncreturns aCipherOrganizationDetailswhich is then passed intoCreateAttachmentForDelayedUploadAsync/CreateAttachmentAsync. These methods cast the cipher toCipherDetailswhen callingReplaceAsync, butCipherOrganizationDetailsis a parent ofCipherDetails, so the downcast fails with anInvalidCastException.Fix
Use pattern matching (
is CipherDetails) to call the appropriateReplaceAsyncoverload. When the cipher is aCipherDetails, use the specific overload; otherwise fall back to the baseReplaceAsync(Cipher)overload.Applied to all three occurrences in
CipherService.cs:CreateAttachmentForDelayedUploadAsyncCreateAttachmentAsyncDeleteAttachmentAsync