Skip to content

[PM-33298] Fix InvalidCastException when uploading attachments as admin #7175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boris324 wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −3
Open

[PM-33298] Fix InvalidCastException when uploading attachments as admin #7175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions src/Core/Vault/Services/Implementations/CipherService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,14 @@ await _cipherRepository.UpdateAttachmentAsync(new CipherAttachment

// Update the revision date when an attachment is added
cipher.RevisionDate = DateTime.UtcNow;
await _cipherRepository.ReplaceAsync((CipherDetails)cipher);
if (cipher is CipherDetails cipherDetails)
{
await _cipherRepository.ReplaceAsync(cipherDetails);
}
else
{
await _cipherRepository.ReplaceAsync(cipher);
}

await _pushService.PushSyncCipherUpdateAsync(cipher, null);

Expand Down Expand Up @@ -287,7 +294,14 @@ public async Task CreateAttachmentAsync(Cipher cipher, Stream stream, string fil

// Update the revision date when an attachment is added
cipher.RevisionDate = DateTime.UtcNow;
await _cipherRepository.ReplaceAsync((CipherDetails)cipher);
if (cipher is CipherDetails cipherDetails)
{
await _cipherRepository.ReplaceAsync(cipherDetails);
}
else
{
await _cipherRepository.ReplaceAsync(cipher);
}

// push
await _pushService.PushSyncCipherUpdateAsync(cipher, null);
Expand Down Expand Up @@ -898,9 +912,13 @@ private async Task<DeleteAttachmentResponseData> DeleteAttachmentAsync(Cipher ci
{
await _cipherRepository.ReplaceAsync(cipher);
}
else if (cipher is CipherDetails cipherDetails)
{
await _cipherRepository.ReplaceAsync(cipherDetails);
}
else
{
await _cipherRepository.ReplaceAsync((CipherDetails)cipher);
await _cipherRepository.ReplaceAsync(cipher);
}

// push
Expand Down
Loading