fix(cli): wire SQUAD_TEAM_ROOT into squad resolution for subprocess compatibility (#734) by AmandaSilver · Pull Request #763 · bradygaster/squad

AmandaSilver · 2026-04-02T21:53:21Z

What

Wires the --team-root\ / \SQUAD_TEAM_ROOT\ env var into the
esolveSquad()\ calls for the
ap, \status, and \cost\ commands. Previously the flag was parsed at CLI entry but never passed through to resolution.

Why

\squad nap\ (and other commands) fail when invoked as a subprocess where \process.cwd()\ differs from the interactive shell — e.g. Copilot CLI bang commands (!squad nap) on Windows (#734). The --team-root\ flag was already parsed and stored in \SQUAD_TEAM_ROOT, but no command ever read it.

How

Added \getSquadStartDir()\ helper: returns \SQUAD_TEAM_ROOT ?? process.cwd()\
Updated 3
esolveSquad(process.cwd())\ calls to use
esolveSquad(getSquadStartDir())\
Improved nap error message to show the searched directory and suggest --team-root\

Testing

5 new tests in \ est/cli/nap-subprocess.test.ts\ (all pass)
42 existing nap tests still pass
No functional change when \SQUAD_TEAM_ROOT\ is unset (falls back to \process.cwd())

Files Changed

\packages/squad-cli/src/cli-entry.ts\ — \getSquadStartDir()\ + 3 call-site updates
\ est/cli/nap-subprocess.test.ts\ — 5 new tests
.changeset/fix-nap-subprocess-cwd.md\ — patch changeset

Exports

N/A — no new public API

Breaking Changes

None — additive behavior only. Existing invocations are unchanged.

Waivers

None

Closes #734

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Copilot

Pull request overview

This PR fixes a CLI wiring gap where --team-root / SQUAD_TEAM_ROOT was parsed but not used when resolving the active .squad/ directory, improving reliability when squad is invoked from subprocesses whose process.cwd() differs from the interactive shell (notably Copilot CLI bang commands on Windows).

Changes:

Added getSquadStartDir() in cli-entry.ts to prefer SQUAD_TEAM_ROOT over process.cwd().
Updated status, cost, and nap to resolve squads starting from getSquadStartDir().
Added a new test file and a patch changeset; improved nap “no squad found” error to include the searched directory and hint --team-root.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
`packages/squad-cli/src/cli-entry.ts`	Adds `getSquadStartDir()` and uses it to drive squad resolution for `status`, `cost`, and `nap`; improves the `nap` missing-squad error message.
`test/cli/nap-subprocess.test.ts`	Adds tests intended to cover subprocess/`--team-root` scenarios for `nap`.
`.changeset/fix-nap-subprocess-cwd.md`	Adds a patch changeset describing the CLI fix and its motivation.

test/cli/nap-subprocess.test.ts

github-actions · 2026-04-04T18:50:15Z

🟡 Impact Analysis — PR #763

Risk tier: 🟡 MEDIUM

📊 Summary

Metric	Count
Files changed	3
Files added	2
Files modified	1
Files deleted	0
Modules touched	3

🎯 Risk Factors

3 files changed (≤5 → LOW)
3 modules touched (2-4 → MEDIUM)

📦 Modules Affected

root (1 file)

.changeset/fix-nap-subprocess-cwd.md

squad-cli (1 file)

packages/squad-cli/src/cli-entry.ts

tests (1 file)

test/cli/nap-subprocess.test.ts

This report is generated automatically for every PR. See #733 for details.

github-actions · 2026-04-04T18:50:15Z

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit 17d780a

⚠️ 2 item(s) to address before review

Status	Check	Details
✅	Single commit	1 commit — clean history
✅	Not in draft	Ready for review
✅	Branch up to date	Up to date with dev
❌	Copilot review	No Copilot review yet — it may still be processing
✅	Changeset present	Changeset file found
✅	Scope clean	No .squad/ or docs/proposals/ files
✅	No merge conflicts	No merge conflicts
✅	Copilot threads resolved	0 active Copilot thread(s) resolved (2 outdated skipped)
❌	CI passing	5 check(s) still running

This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

bradygaster · 2026-04-04T19:03:36Z

packages/squad-cli/src/cli-entry.ts

+ * working directory differs from the interactive shell. (#734)
+ */
+function getSquadStartDir(): string {
+  return process.env['SQUAD_TEAM_ROOT'] || process.cwd();


diberry · 2026-04-04T22:48:31Z

✅ APPROVE WITH FOLLOW-UP

This PR correctly fixes the subprocess invocation issue (#734) where \squad nap\ fails when \process.cwd()\ differs from the project root. The implementation is sound and safe.

Code Review

✅ Correctness: \getSquadStartDir()\ properly implements the fallback pattern:
\\ ypescript
return process.env['SQUAD_TEAM_ROOT'] || process.cwd();
\
Uses short-circuit OR for clean fallback to \process.cwd()\ when env var is unset.

✅ Completeness: All 3
esolveSquad()\ call sites are updated:

ap\ command (line 659)
\status\ command (line 571)
\cost\ command (line 609)

Verified against the diff — no call sites missed.

✅ Security: No path traversal risk. The env var is:

Set by the CLI itself via the --team-root\ flag parsing (controlled input)
Passed directly to
esolveSquad()\ which already validates paths
Only used as a starting point for upward directory traversal (looking for .squad/)

✅ Test Quality: The Copilot bot's review comments were valid when written but are now obsolete — commit 01ed21a (current HEAD) addressed both concerns:

✅ Test now uses \process.chdir(differentCwd)\ to simulate subprocess scenario
✅ Test validates the actual behavior, not just runNap internals

The 5 tests cover:

Subprocess with different cwd (the bug: squad nap fails when invoked via bang command (!) in Windows PowerShell terminal #734 fix scenario)
Non-existent squadDir (error handling)
Integration with actual nap logic (via
unNap)

Existing review threads are correctly marked as resolved/outdated.

✅ Error Message Improvement: The updated nap error is helpful:
\
No squad found (searched from ). Run "squad init" first, or use --team-root to specify the project directory.
\\

Required Actions Before Merge

*Rebase onto \dev* — PR is behind base (mergeable_state: "behind")
Squash 4 commits to 1 — commits should be:
- \ix(cli): wire SQUAD_TEAM_ROOT into squad resolution for subprocess compatibility (bug: squad nap fails when invoked via bang command (!) in Windows PowerShell terminal #734)\
Re-run CI — Squad CI checks not visible on current commit; need verification after rebase

Verdict

APPROVE WITH FOLLOW-UP — Code is production-ready. Merge blocked only by Git hygiene (rebase + squash), not code quality.

cc @AmandaSilver — please rebase onto latest \dev\ and squash to 1 commit, then CI should auto-run. Code review complete ✅

…ompatibility (bradygaster#734) Adds getSquadStartDir() helper that reads SQUAD_TEAM_ROOT env var for nap, status, and cost commands. Previously the --team-root flag was parsed but never passed through to resolveSquad(). - Added getSquadStartDir(): returns SQUAD_TEAM_ROOT ?? process.cwd() - Updated 3 resolveSquad(process.cwd()) calls to use resolveSquad(getSquadStartDir()) - Improved nap error message to show searched directory and suggest --team-root - 5 new tests in test/cli/nap-subprocess.test.ts Closes bradygaster#734 Co-authored-by: AmandaSilver <11282874+AmandaSilver@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

diberry · 2026-04-04T22:56:52Z

Follow-up Issues Created

Two follow-up issues filed to extend this fix:

fix(cli): extend SQUAD_TEAM_ROOT to all resolveSquad() call sites #835 — Extend \SQUAD_TEAM_ROOT\ to all
esolveSquad()\ call sites (currently only nap/status/cost)
test(cli): add Copilot CLI subprocess integration tests for SQUAD_TEAM_ROOT #836 — Add Copilot CLI subprocess integration tests for \SQUAD_TEAM_ROOT\ propagation

These capture the remaining work to make subprocess invocation robust across all commands.

Verifies getSquadStartDir() across all resolution scenarios: env var set, unset, empty, invalid path. Closes #836 Related: PR #763, #835 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

All commands now respect SQUAD_TEAM_ROOT env var for subprocess compatibility. Previously only nap, status, and cost used getSquadStartDir(). Closes #835 Related: PR #763, #734 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Verifies getSquadStartDir() across all resolution scenarios: env var set, unset, empty, invalid path. Closes #836 Related: PR #763, #835 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Verifies getSquadStartDir() across all resolution scenarios: env var set, unset, empty, invalid path. Closes #836 Related: PR #763, #835 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Tamir Dresher <tamir.dresher@gmail.com>

All commands now respect SQUAD_TEAM_ROOT env var for subprocess compatibility. Previously only nap, status, and cost used getSquadStartDir(). Closes #835 Related: PR #763, #734 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Tamir Dresher <tamir.dresher@gmail.com>

AmandaSilver marked this pull request as ready for review April 2, 2026 22:59

Copilot AI review requested due to automatic review settings April 2, 2026 22:59

Copilot started reviewing on behalf of AmandaSilver April 2, 2026 22:59 View session

Copilot AI reviewed Apr 2, 2026

View reviewed changes

test/cli/nap-subprocess.test.ts Outdated Show resolved Hide resolved

test/cli/nap-subprocess.test.ts Outdated Show resolved Hide resolved

bradygaster reviewed Apr 4, 2026

View reviewed changes

diberry force-pushed the squad/734-nap-subprocess-cwd branch from 01ed21a to 17d780a Compare April 4, 2026 22:51

This was referenced Apr 4, 2026

fix(cli): extend SQUAD_TEAM_ROOT to all resolveSquad() call sites #835

Closed

test(cli): add Copilot CLI subprocess integration tests for SQUAD_TEAM_ROOT #836

Closed

diberry merged commit 6f9d965 into bradygaster:dev Apr 4, 2026
17 checks passed

diberry mentioned this pull request Apr 4, 2026

test(cli): add Copilot CLI subprocess integration tests for SQUAD_TEAM_ROOT #838

Merged

diberry mentioned this pull request Apr 4, 2026

fix(cli): extend SQUAD_TEAM_ROOT to all resolveSquad() call sites #841

Merged

jazz127 mentioned this pull request Apr 5, 2026

fix(cli): extend SQUAD_TEAM_ROOT to all resolveSquad() call sites jazz127/squaddev#4

Merged

15 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(cli): wire SQUAD_TEAM_ROOT into squad resolution for subprocess compatibility (#734)#763

fix(cli): wire SQUAD_TEAM_ROOT into squad resolution for subprocess compatibility (#734)#763
diberry merged 1 commit intobradygaster:devfrom
AmandaSilver:squad/734-nap-subprocess-cwd

AmandaSilver commented Apr 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 4, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 4, 2026 •

edited

Loading

Uh oh!

bradygaster Apr 4, 2026

Uh oh!

diberry commented Apr 4, 2026

Uh oh!

diberry commented Apr 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

AmandaSilver commented Apr 2, 2026

What

Why

How

Testing

Files Changed

Exports

Breaking Changes

Waivers

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟡 Impact Analysis — PR #763

📊 Summary

🎯 Risk Factors

📦 Modules Affected

Uh oh!

github-actions bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛫 PR Readiness Check

⚠️ 2 item(s) to address before review

Uh oh!

bradygaster Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

diberry commented Apr 4, 2026

✅ APPROVE WITH FOLLOW-UP

Code Review

Required Actions Before Merge

Verdict

Uh oh!

diberry commented Apr 4, 2026

Follow-up Issues Created

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Apr 4, 2026 •

edited

Loading

github-actions bot commented Apr 4, 2026 •

edited

Loading