[ENH] Rework data upload and some util functions #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anibalsolon
changed the title
soichih
reviewed
Aug 30, 2022
| let program = new commander.Command(); | ||
| program | ||
| .storeOptionsAsProperties(true) | ||
| .argument('task-id', 'Id of the task to wait for') |
Contributor
There was a problem hiding this comment.
I think we should keep -id --id options to make it backward compatible.
Contributor
|
Thanks for the PR @anibalsolon !! Are you going to update other CLIs also? I believe we need to patch all commands since we are upgrading commander? |
Member
Author
|
@soichih Yes! I will work on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives some structure for the cli commands, handling common errors and async/promise instead of callbacks.
For data upload, it uses the commander parsing to verify the arguments.
It solves these two issues + the start for commander upgrade:
#51
https://github.com/brainlife/brainlife/issues/200