Skip to content
This repository was archived by the owner on Dec 30, 2019. It is now read-only.

Adding support for isDestroyed function#59

Closed
vitaly-t wants to merge 1 commit intobrianc:masterfrom
vitaly-t:patch-1
Closed

Adding support for isDestroyed function#59
vitaly-t wants to merge 1 commit intobrianc:masterfrom
vitaly-t:patch-1

Conversation

@vitaly-t
Copy link

@vitaly-t vitaly-t commented Jun 2, 2017

This can be done without reliance on the generic-pool, by introducing an internal flag to be set when .end() is called.

In this case the function can be replaced with a property, perhaps.

Anyway, this one will work just fine for the moment.

This can be done without reliance on the `generic-pool`, by introducing an internal flag to be set when `.end()` is called.

In this case the function can be replaced with a property, perhaps.

Anyway, this one will work just fine for the moment.
@brianc
Copy link
Owner

brianc commented Jul 14, 2017

in pg-pool 2.0 you can check pool.ending to see if the pool is in the process of shutting down.

@brianc brianc closed this Jul 14, 2017
@vitaly-t
Copy link
Author

vitaly-t commented Jul 15, 2017

Excellent! :) 👍

@brianc
When can we expect this latest version of pg-pool to be used by the node-postgres? It is currently using version 1.*.

@charmander
Copy link
Collaborator

@vitaly-t pg-pool 2.x will be used in pg 7.x.

@brianc
Copy link
Owner

brianc commented Jul 15, 2017

@vitaly-t - also the pool is backwards compatible with pg@5.x and pg@6.x - it's only going to be installed by default when installing pg@7.x because pg-pool@2.x drops support for node<4.x and has a few other minor backwards incompatibilities I tried to outline here: #67 ... but if you wanna use it or try it out right now it should work now.

I hope to be done with pg@7.x this weekend!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants