Skip to content

agency: trailing ✓ suffix on picked button (visibility fix) #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MagMueller merged 1 commit into from
May 8, 2026
+21 −8
Merged

agency: trailing ✓ suffix on picked button (visibility fix) #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions agent/telegram_bot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6102,18 +6102,29 @@ def _agency_mark_picked(
kbd: list,
reset_others: bool = False,
) -> None:
"""Mark the tapped button with a "✓ " prefix, keep all buttons
tappable so the user can re-tap (default kinds) or stack actions
(custom buttons).
"""Mark the tapped button with a trailing " ✓" suffix; keep all
buttons tappable so the user can re-tap (default kinds) or
stack actions (custom buttons).

Suffix > prefix: when a label already starts with a colorful
icon (e.g. "✅ Yes"), a leading "✓ " prefix gets visually
swallowed — two checkmarks fighting for the leading slot,
impossible to spot which one is picked. Trailing " ✓" sits
clearly at the end of the label across all icon shapes.

reset_others=False — additive. Leaves prior ✓ marks intact so
multi-tap on custom buttons accumulates ("Send A" + "Send B").
reset_others=True — exclusive. Strips ✓ from every other button
before marking the new one, so only the latest pick is
highlighted. Use for the default Yes/Skip/Edit set where
the user is changing their mind, not stacking.

Also strips any legacy leading "✓ " prefix from the previous
mark style, so cards posted before this change clean up on
the next tap.
"""
picked_prefix = "✓ "
suffix = " ✓"
legacy_prefix = "✓ "
try:
if idx < 0 or not kbd:
return
Expand All @@ -6124,11 +6135,13 @@ def _agency_mark_picked(
for btn in row:
flat_i += 1
text = btn.get("text") or ""
if text.startswith(legacy_prefix):
text = text[len(legacy_prefix):]
if flat_i == idx:
if not text.startswith(picked_prefix):
text = picked_prefix + text
elif reset_others and text.startswith(picked_prefix):
text = text[len(picked_prefix):]
if not text.endswith(suffix):
text = text + suffix
elif reset_others and text.endswith(suffix):
text = text[: -len(suffix)]
new_row.append({**btn, "text": text})
new_kbd.append(new_row)
self.call(
Expand Down
Loading