agency: trailing ✓ suffix on picked button (visibility fix)#104
Merged
MagMueller merged 1 commit intomainfrom May 8, 2026
Merged
agency: trailing ✓ suffix on picked button (visibility fix)#104MagMueller merged 1 commit intomainfrom
MagMueller merged 1 commit intomainfrom
Conversation
Was: leading "✓ " prefix on the picked button. When the button label already starts with a colorful icon (e.g. "✅ Yes"), the prefix gets visually swallowed — "✓ ✅ Yes" reads as just two checkmarks fighting for the leading slot, and on phone-sized button text it's impossible to spot which one is picked. Now: trailing " ✓" suffix. Conventional "is selected" position, sits cleanly at the end of any label regardless of leading icon. On the default 3-button set this gives "✅ Yes ✓" / "⏭ Skip ✓" / "✏️ Edit ✓" — unambiguous and visible at phone scale. Also strips any legacy "✓ " prefix from prior-style cards on the next tap, so the cleanup is automatic. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
MagMueller
pushed a commit
that referenced
this pull request
May 8, 2026
Magnus reviewed 5 candidate styles posted as cards in TG and picked Style A — bold uppercase letters wrapped with framing arrows. The trailing " ✓" suffix shipped in #104 was visible-but-subtle: easy to miss at phone scale next to a button label that already leads with a colorful icon. Style A makes the picked button visibly heavier than its siblings regardless of icon shape. Picked transformation: ✅ Yes → ▶ ✅ 𝗬𝗘𝗦 ◀ ⏭ Skip → ▶ ⏭ 𝗦𝗞𝗜𝗣 ◀ ✏️ Edit → ▶ ✏️ 𝗘𝗗𝗜𝗧 ◀ Send draft A → ▶ 𝗦𝗘𝗡𝗗 𝗗𝗥𝗔𝗙𝗧 𝗔 ◀ Bold uppercase uses Mathematical Sans-Serif Bold (U+1D5D4 onward). Emojis, digits, and punctuation pass through unchanged. Restoring the original label on un-pick uses the suggestion's buttons_json from agency.db (lossless). When buttons_json isn't available we fall back to lossy un-bold (case collapses to upper) — acceptable for the default Yes/Skip/Edit set since "YES" is fine. Module-level helpers added: _agency_bold_upper, _agency_unbold, _agency_pick_label, _agency_is_picked, _agency_strip_legacy_marks, _agency_unpick_label. Legacy "✓ " prefix (#103) and " ✓" suffix (#104) marks are still recognized + cleaned up on the next tap so in-flight cards from before this change tidy up automatically. Default kinds (action/dismiss/refine) keep reset_others=True so only the latest pick is highlighted. Custom kinds stay additive so variant-picker patterns ("Send draft A" + "Send draft B") still stack visibly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
MagMueller
added a commit
that referenced
this pull request
May 8, 2026
Magnus reviewed 5 candidate styles posted as cards in TG and picked Style A — bold uppercase letters wrapped with framing arrows. The trailing " ✓" suffix shipped in #104 was visible-but-subtle: easy to miss at phone scale next to a button label that already leads with a colorful icon. Style A makes the picked button visibly heavier than its siblings regardless of icon shape. Picked transformation: ✅ Yes → ▶ ✅ 𝗬𝗘𝗦 ◀ ⏭ Skip → ▶ ⏭ 𝗦𝗞𝗜𝗣 ◀ ✏️ Edit → ▶ ✏️ 𝗘𝗗𝗜𝗧 ◀ Send draft A → ▶ 𝗦𝗘𝗡𝗗 𝗗𝗥𝗔𝗙𝗧 𝗔 ◀ Bold uppercase uses Mathematical Sans-Serif Bold (U+1D5D4 onward). Emojis, digits, and punctuation pass through unchanged. Restoring the original label on un-pick uses the suggestion's buttons_json from agency.db (lossless). When buttons_json isn't available we fall back to lossy un-bold (case collapses to upper) — acceptable for the default Yes/Skip/Edit set since "YES" is fine. Module-level helpers added: _agency_bold_upper, _agency_unbold, _agency_pick_label, _agency_is_picked, _agency_strip_legacy_marks, _agency_unpick_label. Legacy "✓ " prefix (#103) and " ✓" suffix (#104) marks are still recognized + cleaned up on the next tap so in-flight cards from before this change tidy up automatically. Default kinds (action/dismiss/refine) keep reset_others=True so only the latest pick is highlighted. Custom kinds stay additive so variant-picker patterns ("Send draft A" + "Send draft B") still stack visibly. Co-authored-by: bux <bux@browser-use.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick visibility fix on top of #103.
Symptom
Magnus tapped Yes on a card and asked "is it possible to highlight the button after I press it" — implying he didn't see any change. Bot logs confirmed `editMessageReplyMarkup → 200 OK` fired, so the mark was being applied — just invisible.
Root cause
The mark was a leading `✓ ` prefix. When the button label already starts with a colorful icon (e.g. `✅ Yes`), the prefix collides with it: `✓ ✅ Yes` reads as two checkmarks fighting for the leading slot. On phone-sized button text it's impossible to tell which one is picked.
Fix
Move the mark to a trailing ` ✓` suffix — the conventional "is selected" position. Sits cleanly at the end of any label regardless of leading icon:
Also strips legacy `✓ ` prefix on the next tap so cards posted before this change clean up automatically.
Test plan
Summary by cubic
Moved the picked-button mark from a leading
✓to a trailing✓so selections are clearly visible even when labels start with emoji (e.g.,✅ Yes). Also cleans up old prefix marks on the next tap.reset_others: exclusive for default Yes/Skip/Edit; additive for custom buttons.✓prefix and replaces it with✓on tap.Written for commit 165b59e. Summary will update on new commits.