Skip to content

ci: remove package smoke workflow - #1624

Open
thymikee wants to merge 2 commits into
mainfrom
agent/remove-package-smoke-ci
Open

ci: remove package smoke workflow#1624
thymikee wants to merge 2 commits into
mainfrom
agent/remove-package-smoke-ci

Conversation

@thymikee

@thymikee thymikee commented Aug 5, 2026

Copy link
Copy Markdown
Member

Summary

Remove the standalone macOS Package Smoke workflow, so pnpm prepack no longer runs for matching CI changes.

The complete package build remains available as a local pre-publish sanity check. The main CI Node 22.12 packaged-CLI verification remains in place, and the obsolete workflow assertion is removed.

Validation

pnpm check:affected --run passed, including package tarball verification, coverage, Node integration, and replay-compat provenance. Native/device lanes remain GitHub-authoritative.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
JS raw 1.97 MB 1.97 MB +565 B
JS gzip 631.5 kB 631.7 kB +150 B
npm tarball 761.5 kB 761.6 kB +66 B
npm unpacked 2.67 MB 2.67 MB +565 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 28.0 ms 30.1 ms +2.1 ms
CLI --help 66.1 ms 66.9 ms +0.8 ms

Top changed chunks:

Chunk Raw diff Gzip diff
dist/src/internal/daemon.js +836 B +265 B
dist/src/sdk-batch-runner.js -53 B -51 B
dist/src/session.js +58 B +34 B
dist/src/screenshot-geometry.js +103 B +31 B
dist/src/viewport-dimension.js +163 B +21 B

@thymikee

thymikee commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

P1 — removing this workflow eliminates the only PR/main CI job that runs the complete pnpm prepack path. package:npm builds and packages the iOS/macOS/tvOS/visionOS runners, clean macOS helper, Apple runner source, and Android helpers before tarball validation. The retained Packaged CLI Node 22.12 job runs only pnpm build plus scripts/check-package.ts; it validates JS and already-existing artifacts but never creates or checks the native artifacts that npm publishes. Platform smoke lanes compile/run subsets separately and do not cover full npm packaging, stripping, all shipped Apple targets, or Android packaging. A packaging regression could therefore pass every PR check and surface only during publish—or ship incomplete native content.

Retain Package Smoke or replace it with an equivalent mandatory macOS full-prepack job before removing the workflow assertion and check mapping. Exact head is mergeable and completed checks are green, but this release-safety gap blocks readiness.

@thymikee
thymikee marked this pull request as ready for review August 5, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant