Skip to content

ci: remove package smoke workflow #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thymikee wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −85
Open

ci: remove package smoke workflow #1624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3212f29
ci: remove package smoke workflow
thymikee Aug 5, 2026
cdbc3cb
ci: align affected package check
thymikee Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 0 additions & 69 deletions .github/workflows/package-smoke.yml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion scripts/check-affected/checks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ export const CHECK_CATALOG: readonly CheckSpec[] = [
id: 'package',
label: 'Published package (publint, attw, clean-install resolution)',
kind: { type: 'script', script: 'check:package' },
ciJobs: ['Packaged CLI Node 22.12', 'Build npm package'],
ciJobs: ['Packaged CLI Node 22.12'],
// Needs a `pnpm build` output and the npm registry, both of which local runs already have.
localRunnable: true,
},
Expand Down
15 changes: 0 additions & 15 deletions src/__tests__/npm-package-scripts.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@ const perfNightlyWorkflow = fs.readFileSync(
path.join(repoRoot, '.github', 'workflows', 'perf-nightly.yml'),
'utf8',
);
const packageSmokeWorkflow = fs.readFileSync(
path.join(repoRoot, '.github', 'workflows', 'package-smoke.yml'),
'utf8',
);
const packagedCliWorkflow = fs.readFileSync(
path.join(repoRoot, '.github', 'workflows', 'ci.yml'),
'utf8',
Expand All @@ -31,17 +27,6 @@ test('prepack builds the complete package without stopping the development daemo
assert.equal(script('prepack'), 'pnpm check:mcp-metadata && pnpm package:npm');
assert.doesNotMatch(script('package:npm'), /clean:daemon|rebuild:cli/);
assert.equal(packageJson.scripts['build:dev'], undefined);
assert.match(packageSmokeWorkflow, /run: pnpm prepack/);
for (const input of [
'pnpm-workspace.yaml',
'packages/**',
'scripts/patch-xcuitest-runner-icon.ts',
'scripts/sync-mcp-metadata.mjs',
'scripts/write-xcuitest-cache-metadata.mjs',
'.github/actions/setup-node-pnpm/**',
]) {
assert.ok(packageSmokeWorkflow.includes(`- '${input}'`));
}
});

test('perf uses one platform-selectable entry point', () => {
Expand Down
Loading