chore: install node-gyp@9 in dockerfiles and shell scripts where needed; bump to node 18.18.2 and update base images to latest; use node 18 to run release workflow, not node 16; update docs accordingly as well by nickboldt · Pull Request #309 · che-incubator/che-code

nickboldt · 2023-11-21T12:39:57Z

What does this PR do?

chore: install node-gyp@9 in dockerfiles and shell scripts where needed; bump to node 18.18.2 and update base images to latest; use node 18 to run release workflow, not node 16; update docs accordingly as well

Change-Id: I7598fd90b5e9139f09f8e9b6d8f71db02ca37881
Signed-off-by: nickboldt nickboldt@gmail.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

continues from #305

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

…ed; add node-gyp@9 to package.json too; bump to node 18.18.2 and update base images to latest Change-Id: I7598fd90b5e9139f09f8e9b6d8f71db02ca37881 Signed-off-by: nickboldt <nickboldt@gmail.com>

github-actions · 2023-11-21T12:40:09Z

Click here to review and test in web IDE:

github-actions · 2023-11-21T12:42:50Z

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-309-dev-amd64

Change-Id: Iac88b61a1e36ca50869e9be039094e1d32f60664 Signed-off-by: nickboldt <nickboldt@gmail.com>

github-actions · 2023-11-21T12:45:52Z

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-309-dev-amd64

code/.devcontainer/Dockerfile

package.json

Change-Id: Ieaad6f1e923d2ce1d80832e419cc881ccadee43a Signed-off-by: nickboldt <nickboldt@gmail.com>

Change-Id: Ib71e3db5f5028515b237fc392e1dc49f87e59b39 Signed-off-by: nickboldt <nickboldt@gmail.com>

Change-Id: I2908ea0bd515d23773dd160637b2a9a11967ed3e Signed-off-by: nickboldt <nickboldt@gmail.com>

github-actions · 2023-11-21T13:13:58Z

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-309-dev-amd64

github-actions · 2023-11-21T13:16:03Z

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-309-dev-amd64

github-actions · 2023-11-21T13:16:23Z

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-309-dev-amd64

This reverts commit d5c56e3.

github-actions · 2023-11-21T13:19:34Z

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-309-dev-amd64

github-actions · 2023-11-21T18:57:52Z

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-309-dev-amd64

github-actions · 2023-11-21T19:00:26Z

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-309-dev-amd64

github-actions · 2023-11-21T19:01:42Z

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-309-dev-amd64

Change-Id: Ibe4b5a93f31ef2190823c2ab34f626dfe9d8b6f9 Signed-off-by: nickboldt <nickboldt@gmail.com>

github-actions · 2023-11-21T19:05:26Z

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-309-dev-amd64

github-actions · 2023-11-21T19:40:21Z

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-309-amd64

github-actions · 2023-11-21T19:43:51Z

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-309-amd64

github-actions · 2023-11-21T19:46:00Z

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-309-amd64

github-actions · 2023-11-21T19:47:59Z

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-309-amd64

SDawley · 2023-12-06T19:19:22Z

Haven't tested but looks good to me.

build/dockerfiles/linux-musl.Dockerfile

build/dockerfiles/linux-libc.Dockerfile

RomanNikitenko

LGTM

mkuznyetsov · 2023-12-07T11:46:41Z

having explicitly declaring version of node-gyp in this project will help to keep it the same, when syncing with Devspaces build midstream

github-actions · 2023-12-07T16:22:19Z

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-309-dev-amd64

github-actions · 2023-12-07T17:06:22Z

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-309-amd64

devstudio-release · 2023-12-07T17:07:42Z

Build 3.12 :: code_3.x/1075: Console, Changes, Git Data

devstudio-release · 2023-12-07T19:57:59Z

Build 3.12 :: code_3.x/1076: Console, Changes, Git Data

devstudio-release · 2023-12-07T20:08:49Z

Build 3.12 :: code_3.x/1077: Console, Changes, Git Data

devstudio-release · 2023-12-07T20:25:28Z

Build 3.12 :: code_3.x/1078: Console, Changes, Git Data

chore: install node-gyp@9 in dockerfiles and shell scripts where need…

f3e9043

…ed; add node-gyp@9 to package.json too; bump to node 18.18.2 and update base images to latest Change-Id: I7598fd90b5e9139f09f8e9b6d8f71db02ca37881 Signed-off-by: nickboldt <nickboldt@gmail.com>

nickboldt requested review from RomanNikitenko, azatsarynnyy, l0rd and vitaliy-guliy as code owners November 21, 2023 12:39

yarn already installed in musl builder

ff08750

Change-Id: Iac88b61a1e36ca50869e9be039094e1d32f60664 Signed-off-by: nickboldt <nickboldt@gmail.com>

nickboldt enabled auto-merge (squash) November 21, 2023 12:43

RomanNikitenko reviewed Nov 21, 2023

View reviewed changes

code/.devcontainer/Dockerfile Outdated Show resolved Hide resolved

RomanNikitenko reviewed Nov 21, 2023

View reviewed changes

code/.devcontainer/Dockerfile Outdated Show resolved Hide resolved

RomanNikitenko reviewed Nov 21, 2023

View reviewed changes

package.json Show resolved Hide resolved

nickboldt added 3 commits November 21, 2023 09:11

try to work around electronjs tarball fetch failure

d5c56e3

Change-Id: Ieaad6f1e923d2ce1d80832e419cc881ccadee43a Signed-off-by: nickboldt <nickboldt@gmail.com>

remove header from upstream file that we ship for some reason

c9f4976

Change-Id: Ib71e3db5f5028515b237fc392e1dc49f87e59b39 Signed-off-by: nickboldt <nickboldt@gmail.com>

remove changes from upstream dockerfile

df6e23a

Change-Id: I2908ea0bd515d23773dd160637b2a9a11967ed3e Signed-off-by: nickboldt <nickboldt@gmail.com>

Revert "try to work around electronjs tarball fetch failure"

91d1409

This reverts commit d5c56e3.

Merge branch 'main' into install-node-gyp_main

53056e3

nickboldt disabled auto-merge November 21, 2023 18:55

nickboldt changed the title ~~chore: install node-gyp@9 in dockerfiles and...~~ chore: install node-gyp@9 in dockerfiles and shell scripts where needed; add node-gyp@9 to package.json too; bump to node 18.18.2 and update base images to latest Nov 21, 2023

nickboldt requested a review from RomanNikitenko November 21, 2023 18:59

revert

3aa79e3

Change-Id: Ibe4b5a93f31ef2190823c2ab34f626dfe9d8b6f9 Signed-off-by: nickboldt <nickboldt@gmail.com>

nickboldt force-pushed the install-node-gyp_main branch from 5e3070e to 3aa79e3 Compare November 21, 2023 19:02

RomanNikitenko reviewed Dec 7, 2023

View reviewed changes

build/dockerfiles/linux-musl.Dockerfile Show resolved Hide resolved

RomanNikitenko reviewed Dec 7, 2023

View reviewed changes

build/dockerfiles/linux-libc.Dockerfile Outdated Show resolved Hide resolved

RomanNikitenko approved these changes Dec 7, 2023

View reviewed changes

mkuznyetsov approved these changes Dec 7, 2023

View reviewed changes

Update build/dockerfiles/linux-libc.Dockerfile

f144cab

nickboldt enabled auto-merge (squash) December 7, 2023 16:20

nickboldt merged commit 8c790c2 into main Dec 7, 2023

nickboldt deleted the install-node-gyp_main branch December 7, 2023 17:06

Conversation

nickboldt commented Nov 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Reviewers

Uh oh!

github-actions bot commented Nov 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 21, 2023

Uh oh!

github-actions bot commented Nov 21, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 21, 2023

Uh oh!

github-actions bot commented Nov 21, 2023

Uh oh!

github-actions bot commented Nov 21, 2023

Uh oh!

github-actions bot commented Nov 21, 2023

Uh oh!

github-actions bot commented Nov 21, 2023

Uh oh!

github-actions bot commented Nov 21, 2023

Uh oh!

github-actions bot commented Nov 21, 2023

Uh oh!

github-actions bot commented Nov 21, 2023

Uh oh!

github-actions bot commented Nov 21, 2023

Uh oh!

github-actions bot commented Nov 21, 2023

Uh oh!

github-actions bot commented Nov 21, 2023

Uh oh!

github-actions bot commented Nov 21, 2023

Uh oh!

SDawley commented Dec 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RomanNikitenko left a comment

Choose a reason for hiding this comment

Uh oh!

mkuznyetsov commented Dec 7, 2023

Uh oh!

github-actions bot commented Dec 7, 2023

Uh oh!

github-actions bot commented Dec 7, 2023

Uh oh!

devstudio-release commented Dec 7, 2023

Uh oh!

devstudio-release commented Dec 7, 2023

Uh oh!

devstudio-release commented Dec 7, 2023

Uh oh!

devstudio-release commented Dec 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nickboldt commented Nov 21, 2023 •

edited

Loading

github-actions bot commented Nov 21, 2023 •

edited

Loading

SDawley commented Dec 6, 2023 •

edited

Loading