docs: update README with task_type options and add comment in cost_manager.py #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nager.py Signed-off-by: ImMin5 <mino@megazone.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project documentation to include task_type options and adds clarifying inline comments to support proper tagging in cost management. The key changes are:
- Added a comment in cost_manager.py explaining the update of SpaceONE service account tags.
- Updated the task_type handling in main.py with an inline comment for the "directory" case.
- Revised README.md to show sample configuration options including task_type.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/plugin/manager/cost_manager.py | Added inline comment to denote SpaceONE service account tag update. |
| src/plugin/main.py | Added inline comment clarifying the else branch for 'directory' task_type. |
| README.md | Updated documentation with new task_type options and example configuration. |
| account_id = task_options["account_id"] | ||
| database = task_options["database"] | ||
|
|
||
| # update SpaceONE service account tags info |
There was a problem hiding this comment.
Consider expanding the comment to specify which service account tags are updated and why, to aid future maintenance.
| ```json | ||
|
|
||
| { | ||
| "task_type": "string", |
There was a problem hiding this comment.
[nitpick] Consider using a numeric literal (e.g., 7) for 'resync_days' in the example JSON or clarifying that these values are type descriptors to prevent potential confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.