Skip to content

docs: update README with task_type options and add comment in cost_manager.py #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ImMin5 merged 1 commit into from
May 22, 2025
+19 −1
Merged

docs: update README with task_type options and add comment in cost_manager.py #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,20 @@ Plugin for collecting AWS HyperBilling data

## Options
*Example*
currency: "USD"
task_type: "identity" | "directory"
resync_days: 7

```json

{
"task_type": "string",
Copy link

Copilot AI May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider using a numeric literal (e.g., 7) for 'resync_days' in the example JSON or clarifying that these values are type descriptors to prevent potential confusion.

Copilot uses AI. Check for mistakes.
"currency": "string",
"resync_days": "int"

}


```


2 changes: 1 addition & 1 deletion src/plugin/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def job_get_tasks(params: dict) -> dict:
return job_mgr.get_tasks(
domain_id, options, secret_data, schema, start, last_synchronized_at
)
else:
else: # 'directory' task_type
return job_mgr.get_tasks_directory_type(
domain_id, options, secret_data, schema, start, last_synchronized_at
)
Expand Down
1 change: 1 addition & 0 deletions src/plugin/manager/cost_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ def get_data(
account_id = task_options["account_id"]
database = task_options["database"]

# update SpaceONE service account tags info
Copy link

Copilot AI May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider expanding the comment to specify which service account tags are updated and why, to aid future maintenance.

Copilot uses AI. Check for mistakes.
if task_type == "identity":
service_account_id = task_options["service_account_id"]
is_sync = task_options["is_sync"]
Expand Down
Loading