Skip to content

fix: bump playwright-go to v0.6100.0 (mxschmitt)#1296

Merged
rajivnathan merged 1 commit into
codeready-toolchain:masterfrom
fbm3307:fix/playwright-go-bump
Jul 9, 2026
Merged

fix: bump playwright-go to v0.6100.0 (mxschmitt)#1296
rajivnathan merged 1 commit into
codeready-toolchain:masterfrom
fbm3307:fix/playwright-go-bump

Conversation

@fbm3307

@fbm3307 fbm3307 commented Jul 9, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor
  • Dashboard e2e CI was failing because Playwright browser driver downloads for 1.52.0 returned CDN 404 (retired Azure CDN URLs used by playwright-community/playwright-go v0.5200.0).
  • Bump to github.com/mxschmitt/playwright-go v0.6100.0. The playwright-community org was archived and the project transferred to mxschmitt (same maintainer; see upstream PR #619). This is a module-path rename of the same project, not a different library.
  • v0.6100.0 also updates install to use current Playwright CDN endpoints (npm/nodejs driver install), which resolves the 404.
  • Update imports / go.mod require + tool stanza, go mod tidy, and adapt RecordVideo.Dir to *string for the new API. Makefile still uses go tool playwright install firefox (resolved via the updated tool stanza).

Summary by CodeRabbit

  • Chores
    • Updated the browser automation tooling to a newer supported version.
    • Aligned related test support code with the updated API, including a small configuration adjustment for video/trace capture.
    • Refreshed a transitive library version used by the project.

@fbm3307 @cursoragent
fix: bump playwright-go to v0.6100.0 (mxschmitt)
18f4d80 
- Move module path from playwright-community to mxschmitt: the
  playwright-community org was archived and the project transferred to
  mxschmitt (same maintainer; upstream PR codeready-toolchain#619).
- v0.6100.0 also fixes retired Azure CDN driver downloads that caused
  404s when installing Playwright 1.52.0 browsers (npm/nodejs install).
- Adapt RecordVideo.Dir to *string for the new API.

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@openshift-ci openshift-ci Bot requested review from alexeykazakov and xcoulon July 9, 2026 14:58
@openshift-ci openshift-ci Bot added the approved label Jul 9, 2026
@coderabbitai

coderabbitai Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 9a145e8a-9ca4-48e3-bcc5-d0849e02ff3a

📥 Commits

Reviewing files that changed from the base of the PR and between b2cd178 and 18f4d80.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (9)
  • go.mod
  • test/e2e/devsandbox-dashboard/activities_page_test.go
  • test/e2e/devsandbox-dashboard/fresh_signup_test.go
  • test/e2e/devsandbox-dashboard/header_test.go
  • testsupport/devsandbox-dashboard/login.go
  • testsupport/devsandbox-dashboard/popup.go
  • testsupport/devsandbox-dashboard/setup.go
  • testsupport/devsandbox-dashboard/trace.go
  • testsupport/devsandbox-dashboard/utils.go
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • codeready-toolchain/api (manual)
  • codeready-toolchain/toolchain-common (manual)
  • codeready-toolchain/host-operator (manual)
  • codeready-toolchain/toolchain-e2e (manual)
📜 Recent review details
⏰ Context from checks skipped due to timeout. (3)
  • GitHub Check: GolangCI Lint
  • GitHub Check: Unit Tests
  • GitHub Check: Build & push operator bundles & dashboard image for e2e tests
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

  • testsupport/devsandbox-dashboard/popup.go
  • test/e2e/devsandbox-dashboard/header_test.go
  • testsupport/devsandbox-dashboard/trace.go
  • testsupport/devsandbox-dashboard/utils.go
  • test/e2e/devsandbox-dashboard/activities_page_test.go
  • testsupport/devsandbox-dashboard/login.go
  • testsupport/devsandbox-dashboard/setup.go
  • go.mod
  • test/e2e/devsandbox-dashboard/fresh_signup_test.go
🔇 Additional comments (9)
go.mod (1)

36-36: LGTM!

Also applies to: 51-51, 149-149

test/e2e/devsandbox-dashboard/activities_page_test.go (1)

8-8: LGTM!

test/e2e/devsandbox-dashboard/fresh_signup_test.go (1)

13-13: LGTM!

test/e2e/devsandbox-dashboard/header_test.go (1)

8-8: LGTM!

testsupport/devsandbox-dashboard/login.go (1)

7-7: LGTM!

testsupport/devsandbox-dashboard/popup.go (1)

11-11: LGTM!

testsupport/devsandbox-dashboard/setup.go (1)

11-11: LGTM!

Also applies to: 61-61

testsupport/devsandbox-dashboard/trace.go (1)

10-10: LGTM!

testsupport/devsandbox-dashboard/utils.go (1)

6-6: LGTM!

Walkthrough

This PR migrates the Playwright Go dependency from github.com/playwright-community/playwright-go to github.com/mxschmitt/playwright-go, updating go.mod and all import references across test and testsupport files, plus one API call adjustment wrapping traceDirectory with playwright.String in setup.go.

Changes

Playwright Go dependency swap

Layer / File(s) Summary
Module dependency update
go.mod		 Replaces the playwright-go require and tool directives with the new module path and bumps the indirect golang-set/v2 dependency.
Testsupport import updates and API adjustment
testsupport/devsandbox-dashboard/login.go, testsupport/devsandbox-dashboard/popup.go, testsupport/devsandbox-dashboard/setup.go, testsupport/devsandbox-dashboard/trace.go, testsupport/devsandbox-dashboard/utils.go		 Updates Playwright import paths and wraps traceDirectory with playwright.String(...) in the RecordVideo.Dir assignment.
E2E test import updates
test/e2e/devsandbox-dashboard/activities_page_test.go, test/e2e/devsandbox-dashboard/fresh_signup_test.go, test/e2e/devsandbox-dashboard/header_test.go		 Updates Playwright import paths in e2e test files without changing test logic.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested labels: dependencies

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: upgrading playwright-go to v0.6100.0 and switching to the mxschmitt module path.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@coderabbitai coderabbitai Bot added the dependencies Pull requests that update a dependency file label Jul 9, 2026
@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, fbm3307

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,fbm3307]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rajivnathan rajivnathan merged commit 4af0bef into codeready-toolchain:master Jul 9, 2026
9 of 11 checks passed
This was referenced Jul 10, 2026
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexeykazakov alexeykazakov alexeykazakov approved these changes
@xcoulon xcoulon Awaiting requested review from xcoulon

Assignees

No one assigned

Labels

approved dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fbm3307 @alexeykazakov @rajivnathan