Skip to content

Unpin jaxtyping#105

Merged
Balandat merged 3 commits intomainfrom
jaxtyping-1
Jan 25, 2025
Merged

Unpin jaxtyping#105
Balandat merged 3 commits intomainfrom
jaxtyping-1

Conversation

@saitcakmak
Copy link
Collaborator

The required jaxtyping version conflicts with the requirements of other libraries. The code appears to be compatible with newer versions, so attempting to unpin to see if anything breaks.

@gpleiss
Copy link
Member

gpleiss commented Jan 23, 2025

Hmm I'm not sure why the docs build is failing. Otherwise lgtm

@saitcakmak saitcakmak enabled auto-merge January 25, 2025 02:09
@saitcakmak saitcakmak disabled auto-merge January 25, 2025 02:49
@saitcakmak
Copy link
Collaborator Author

saitcakmak commented Jan 25, 2025

Actually, even after unpin, the CI seems to be running with 0.2.19 because that's the latest version available in Py3.8, which is what the CI uses. So, the CI passing here is meaningless. I'm getting some weird undefined value torch errors when trying to run pytest --jaxtyping-packages=linear_operator,typeguard.typechecked locally with Py3.10 & jaxtyping 0.2.36

cc @Balandat

@saitcakmak
Copy link
Collaborator Author

Removing linear_operator from the command, pytest --jaxtyping-packages=typeguard.typechecked does pass (as in has the same 3 failures as before) with Py3.10 & jaxtyping 0.2.36. I guess we need to update the CI along with the pin

@saitcakmak
Copy link
Collaborator Author

Ok, CI is also happy (except for docs, which seems unrelated) and running with latest jaxtyping now

@saitcakmak saitcakmak requested a review from Balandat January 25, 2025 03:14
@saitcakmak saitcakmak enabled auto-merge January 25, 2025 03:19
Comment on lines +30 to +31
pip install torch==1.11+cpu -f https://download.pytorch.org/whl/torch_stable.html
pip install "numpy<2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is numpy < 2 needed here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

torch=1.11 is not compatible with numpy>2 but it does not explicitly require <2 either, so we end up with CI failing with RuntimeError: Numpy is not available on tensor.numpy() calls despite numpy==2.2.2 being installed. See https://github.com/cornellius-gp/linear_operator/actions/runs/12961267021/job/36156321493

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. torch 1.11 is rather ancient but I guess this is only relevant for the CI testing, so this is fine by me.

@Balandat Balandat disabled auto-merge January 25, 2025 17:26
@Balandat Balandat merged commit d809345 into main Jan 25, 2025
5 of 6 checks passed
@Balandat Balandat deleted the jaxtyping-1 branch January 25, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants