fix multi-image rating toast when clearing on 1-star and un-rejected#21432
Merged
Conversation
TurboGit
added
bugfix
Member
|
Can't be for 5.6.1 as it introduces a new string. Or you may split in two PR, one without the "unrejecting" new string for 5.6.1 and the other for 5.8? |
Contributor
Author
|
@TurboGit I will split this into two PRs it was my initial plan anyways. |
rtmongold
force-pushed
the
fix_multi_image_toast
branch
from
June 28, 2026 06:34
3e8258b to
bb44dcd
Compare
Contributor
Author
|
@TurboGit ok got it split out, and will submit the other PR after this one goes through. Thanks. |
When rating two or more images at once, the status message used the key pressed instead of the rating actually applied to the images. This was visible when toggling 1-star off (double-press 1): images were cleared to 0 stars but the toast still said "applying rating 1 to N images". Changed _ratings_apply() to use a shared _ratings_effective() helper for both the apply loop and a new _ratings_log_multi() toast helper. When all selected images receive the same effective rating, show that value. Rating behavior is unchanged; only on-screen wording is corrected.
rtmongold
force-pushed
the
fix_multi_image_toast
branch
from
July 19, 2026 03:27
bb44dcd to
0d87bdf
Compare
Contributor
Author
rtmongold
changed the title
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21416
5.6.1: #21571
When rating multiple images, the toast used the key pressed or internal
upgrade/downgrade codes instead of the rating actually applied — e.g.
clearing 1-star still said "applying rating 1", and un-reject still said
"rejecting".
Fixed via shared
_ratings_effective()for apply and toast logging.When the selection gets one effective rating, show that value; when
upgrade/downgrade results differ, show a generic "applying ratings to N
images" message; un-reject uses "unrejecting …".
New translatable strings (5.8). Rating behavior unchanged.