fix multi-image rating toast when clearing on 1-star#21571
Open
rtmongold wants to merge 1 commit into
Open
Conversation
When rating two or more images at once, the status message used the key pressed instead of the rating actually applied to the images. This was visible when toggling 1-star off (double-press 1): images were cleared to 0 stars but the toast still said "applying rating 1 to N images". Changed _ratings_apply() to use a shared _ratings_effective() helper for both the apply loop and a new _ratings_log_multi() toast helper. When all selected images receive the same effective rating, show that value. Rating behavior is unchanged; only on-screen wording is corrected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21416
Moved from #21432
When rating multiple images, the toast used the key pressed (or internal
upgrade/downgrade codes) instead of the rating actually applied — e.g.
clearing 1-star still said "applying rating 1".
Fixed by sharing
_ratings_effective()between apply and toast logging.No new strings; rating behavior unchanged.
Added Release Notes.